Skip to content

fix save! did not use passed block #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
langalex merged 1 commit into from
Jan 13, 2026
Merged

fix save! did not use passed block #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/couch_potato/database.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ def save_document(document, options = {}, retries = 0, &block)
alias save save_document

# saves a document, raises a CouchPotato::Database::ValidationsFailedError on failure
def save_document!(document, options = {})
save_document(document, options) || raise(ValidationsFailedError, document.errors.full_messages)
def save_document!(document, options = {}, &block)
save_document(document, options, &block) || raise(ValidationsFailedError, document.errors.full_messages)
end
alias save! save_document!

Expand Down
8 changes: 8 additions & 0 deletions spec/unit/database_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,14 @@ def set_errors
end
end

describe CouchPotato::Database, 'save_document!' do
it 'calls the block if provided' do
doc = double('doc').as_null_object

expect {|b| CouchPotato.database.save_document!(doc, &b)}.to yield_with_args(doc)
end
end

describe CouchPotato::Database, 'first' do
before(:each) do
@couchrest_db = double('couchrest db').as_null_object
Expand Down