Skip to content

chore(ci): move to blacksmith runners#1613

Open
nimarb wants to merge 1 commit intomainfrom
nimar/move-to-blacksmith-runners
Open

chore(ci): move to blacksmith runners#1613
nimarb wants to merge 1 commit intomainfrom
nimar/move-to-blacksmith-runners

Conversation

@nimarb
Copy link
Copy Markdown
Contributor

@nimarb nimarb commented Apr 7, 2026

Disclaimer: Experimental PR review

Greptile Summary

This PR migrates all CI jobs from GitHub-hosted ubuntu-latest runners to Blacksmith runners for improved performance, using blacksmith-2vcpu-ubuntu-2404 for lightweight jobs (linting, type-checking, all-tests-passed) and blacksmith-4vcpu-ubuntu-2404 for the more resource-intensive parallel test matrix job. A trailing whitespace on the pnpm run db:migrate line is also cleaned up.

  • linting: ubuntu-latestblacksmith-2vcpu-ubuntu-2404
  • type-checking: ubuntu-latestblacksmith-2vcpu-ubuntu-2404
  • ci (test matrix, Python 3.10–3.14): ubuntu-latestblacksmith-4vcpu-ubuntu-2404
  • all-tests-passed: ubuntu-latestblacksmith-2vcpu-ubuntu-2404
  • Minor: trailing whitespace removed from pnpm run db:migrate line

Confidence Score: 5/5

This PR is safe to merge — it is a straightforward runner migration with no logic changes.

All changes are limited to the CI runner labels and a minor whitespace fix. The chosen Blacksmith runner sizes are appropriate for each job's workload (2vCPU for linting/type-checking, 4vCPU for the parallel test matrix). No code logic, dependencies, or test behavior is altered.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/ci.yml Migrates all GitHub-hosted ubuntu-latest runners to Blacksmith runners (2vCPU for linting/type-checking/all-tests-passed, 4vCPU for the main CI job); also removes trailing whitespace on line 118.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Push / PR / Merge Group] --> B[linting
blacksmith-2vcpu-ubuntu-2404]
    A --> C[type-checking
blacksmith-2vcpu-ubuntu-2404]
    A --> D[ci matrix
blacksmith-4vcpu-ubuntu-2404
Python 3.10-3.14]
    B --> E[all-tests-passed
blacksmith-2vcpu-ubuntu-2404]
    C --> E
    D --> E
    E --> F{Any failure?}
    F -- No --> G[exit 0]
    F -- Yes --> H[exit 1]
Loading

Reviews (1): Last reviewed commit: "chore(ci): move to blacksmith runners" | Re-trigger Greptile

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

@claude review

Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward runner migration from ubuntu-latest to Blacksmith runners with appropriate vCPU sizing.

Extended reasoning...

Overview

This PR modifies a single file (.github/workflows/ci.yml) to swap GitHub-hosted ubuntu-latest runners for Blacksmith-hosted runners (blacksmith-2vcpu-ubuntu-2404 for linting/type-checking/summary jobs, blacksmith-4vcpu-ubuntu-2404 for the heavier CI matrix job). It also removes a trailing whitespace from one line.

Security Risks

None. This is a CI infrastructure change only — no application code, secrets handling, or permissions are modified. The runner labels are standard Blacksmith runner names and do not introduce any supply-chain concerns beyond what already exists with third-party CI providers.

Level of Scrutiny

Low. Runner changes are mechanical and well-understood. The job logic, steps, and environment variables are entirely unchanged. The vCPU sizing choices (2 for lightweight jobs, 4 for the test matrix) are sensible.

Other Factors

No bugs were found. The change is consistent with the recent commit 48a9453 ("chore(ci): move to blacksmith runners") already on main, suggesting this is part of an established migration pattern in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant