Skip to content

fix: omit flags and segments with errors from sync manifests, so incremental runs can create missing resources#12

Open
nljordan wants to merge 1 commit intolaunchdarkly-labs:mainfrom
nljordan:fix/manifest-errors
Open

fix: omit flags and segments with errors from sync manifests, so incremental runs can create missing resources#12
nljordan wants to merge 1 commit intolaunchdarkly-labs:mainfrom
nljordan:fix/manifest-errors

Conversation

@nljordan
Copy link
Copy Markdown
Contributor

Flags:

  • Only add to manifest when flagCreated && !flagsWithErrors.has(flag.key)
  • Log when a flag is skipped due to errors

Segments:

  • Add segmentsWithErrors set; only add to manifest when patch succeeds (2xx)
  • On patch failure, add to segmentsWithErrors and skip manifest update

Summary:

  • Also log a summary of omitted flags/segments after manifest write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant