refactor: define new Synchronizer and Initializer interfaces for FDv2#517
Merged
refactor: define new Synchronizer and Initializer interfaces for FDv2#517
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
kinyoklion
reviewed
Apr 2, 2026
| */ | ||
| struct Timeout {}; | ||
|
|
||
| using Value = std::variant<ChangeSet, Interrupted, TerminalError, Shutdown, |
Member
There was a problem hiding this comment.
This is nicer than the Java shenanigans.
kinyoklion
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR introduces
IFDv2InitializerandIFDv2Synchronizerinterfaces.I based this on the Java design, but with some significant changes:
Next. I think this is acceptable, as Next only return a single result, which I think will only use one selector. This avoids having to deal with the ownership complications a shared provider would entail.Note
Low Risk
Low risk because it only adds new FDv2 interface headers and a result type without changing existing runtime behavior; main risk is future integration/implementation mismatches around the blocking
Next()timeout/selector contract.Overview
Introduces new FDv2 source abstractions for the server SDK: a one-shot
IFDv2Initializer(blockingRun()+Close()) and a continuousIFDv2Synchronizerwith a blockingNext(timeout, selector)API.Adds
FDv2SourceResultas a unified variant return type covering successful changesets, transient/terminal errors, shutdown, goodbye/rotation signals, and timeout-based wakeups (including anfdv1_fallbackflag where applicable). Also updates.gitignoreto ignore.cache.Written by Cursor Bugbot for commit ed22857. This will update automatically on new commits. Configure here.