chore: use @launchdarkly scoped names in package.json files#518
Merged
kinyoklion merged 1 commit intomainfrom Apr 3, 2026
Merged
chore: use @launchdarkly scoped names in package.json files#518kinyoklion merged 1 commit intomainfrom
kinyoklion merged 1 commit intomainfrom
Conversation
Update all package.json name fields from launchdarkly-cpp-* to @launchdarkly/cpp-* and update dependency references to match. Add explicit component fields to release-please-config.json to preserve existing git tag format (launchdarkly-cpp-*-v<version>) since release-please strips the @scope/ prefix by default. Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
joker23
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates all 8
package.jsonfiles to use@launchdarkly/-scoped package names (e.g.@launchdarkly/cpp-clientinstead oflaunchdarkly-cpp-client). Thesepackage.jsonfiles are not published npm packages — they exist solely to model the inter-package dependency graph for release-please'snode-workspaceplugin.To prevent the name change from altering git tag format (release-please strips the
@scope/prefix by default, which would change tags fromlaunchdarkly-cpp-client-v3.11.1tocpp-client-v3.11.1), explicit"component"overrides have been added to each package inrelease-please-config.json. This preserves the existinglaunchdarkly-cpp-*-v<version>tag format.No changes to versions, dependency graph structure, CMake targets, build scripts, CI workflows, or workflow outputs.
Review & Testing Checklist for Human
component+node-workspaceinteraction: Confirm that release-please respects the"component"field when thenode-workspaceplugin is active with scoped package names. This cannot be tested locally — it only runs on push tomain. Consider doing a dry run or checking release-please source/docs for confirmation.dependenciesreference across all 8package.jsonfiles should use the new@launchdarkly/prefix. A stale reference would break thenode-workspaceplugin's graph resolution."component"value inrelease-please-config.jsonshould exactly match the previous"name"from the correspondingpackage.json(e.g.libs/server-sent-eventshad namelaunchdarkly-cpp-sse-client, and the component islaunchdarkly-cpp-sse-client).Notes
js-corerepo already uses@launchdarkly/-scoped names with thenode-workspaceplugin successfully, which gives some confidence this pattern works. However,js-coredoes not use explicitcomponentoverrides — its tags use the stripped names (e.g.js-client-sdk-v4.4.1). So the combination of scoped names + component overrides innode-workspaceis the novel part here.Link to Devin session: https://app.devin.ai/sessions/37efb8037fa940deb4938b906a1a42ad
Requested by: @kinyoklion
Note
Low Risk
Low risk: only updates release-please/node-workspace metadata (package names and dependency references) without touching runtime code. Main risk is misconfiguration causing incorrect tag naming or dependency graph resolution in the release process.
Overview
Updates the workspace
package.jsonmetadata to use@launchdarkly/-scoped names and updates all inter-packagedependenciesto reference the scoped packages.Adjusts
release-please-config.jsonto add explicitcomponentvalues for each package so release-please continues generating the existinglaunchdarkly-cpp-*-v<version>tag/component names despite the new scoped package names.Written by Cursor Bugbot for commit 5db44f1. This will update automatically on new commits. Configure here.