Skip to content

chore: use @launchdarkly scoped names in package.json files#518

Merged
kinyoklion merged 1 commit intomainfrom
devin/1775152941-scoped-package-names
Apr 3, 2026
Merged

chore: use @launchdarkly scoped names in package.json files#518
kinyoklion merged 1 commit intomainfrom
devin/1775152941-scoped-package-names

Conversation

@kinyoklion
Copy link
Copy Markdown
Member

@kinyoklion kinyoklion commented Apr 2, 2026

Summary

Updates all 8 package.json files to use @launchdarkly/-scoped package names (e.g. @launchdarkly/cpp-client instead of launchdarkly-cpp-client). These package.json files are not published npm packages — they exist solely to model the inter-package dependency graph for release-please's node-workspace plugin.

To prevent the name change from altering git tag format (release-please strips the @scope/ prefix by default, which would change tags from launchdarkly-cpp-client-v3.11.1 to cpp-client-v3.11.1), explicit "component" overrides have been added to each package in release-please-config.json. This preserves the existing launchdarkly-cpp-*-v<version> tag format.

No changes to versions, dependency graph structure, CMake targets, build scripts, CI workflows, or workflow outputs.

Review & Testing Checklist for Human

  • Verify component + node-workspace interaction: Confirm that release-please respects the "component" field when the node-workspace plugin is active with scoped package names. This cannot be tested locally — it only runs on push to main. Consider doing a dry run or checking release-please source/docs for confirmation.
  • Verify dependency graph is fully updated: Every dependencies reference across all 8 package.json files should use the new @launchdarkly/ prefix. A stale reference would break the node-workspace plugin's graph resolution.
  • Spot-check component values match old names: Each "component" value in release-please-config.json should exactly match the previous "name" from the corresponding package.json (e.g. libs/server-sent-events had name launchdarkly-cpp-sse-client, and the component is launchdarkly-cpp-sse-client).

Notes

  • The js-core repo already uses @launchdarkly/-scoped names with the node-workspace plugin successfully, which gives some confidence this pattern works. However, js-core does not use explicit component overrides — its tags use the stripped names (e.g. js-client-sdk-v4.4.1). So the combination of scoped names + component overrides in node-workspace is the novel part here.
  • Recommended test plan: After merge, monitor the next release-please PR to confirm it generates correct tag names and updates dependency versions as expected.

Link to Devin session: https://app.devin.ai/sessions/37efb8037fa940deb4938b906a1a42ad
Requested by: @kinyoklion


Note

Low Risk
Low risk: only updates release-please/node-workspace metadata (package names and dependency references) without touching runtime code. Main risk is misconfiguration causing incorrect tag naming or dependency graph resolution in the release process.

Overview
Updates the workspace package.json metadata to use @launchdarkly/-scoped names and updates all inter-package dependencies to reference the scoped packages.

Adjusts release-please-config.json to add explicit component values for each package so release-please continues generating the existing launchdarkly-cpp-*-v<version> tag/component names despite the new scoped package names.

Written by Cursor Bugbot for commit 5db44f1. This will update automatically on new commits. Configure here.

Update all package.json name fields from launchdarkly-cpp-* to
@launchdarkly/cpp-* and update dependency references to match.

Add explicit component fields to release-please-config.json to
preserve existing git tag format (launchdarkly-cpp-*-v<version>)
since release-please strips the @scope/ prefix by default.

Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@kinyoklion kinyoklion marked this pull request as ready for review April 2, 2026 19:54
@kinyoklion kinyoklion requested a review from a team as a code owner April 2, 2026 19:54
@kinyoklion kinyoklion merged commit b741911 into main Apr 3, 2026
46 checks passed
@kinyoklion kinyoklion deleted the devin/1775152941-scoped-package-names branch April 3, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants