Skip to content

Conversation

@kinyoklion
Copy link
Member

@kinyoklion kinyoklion commented Jan 29, 2026

BEGIN_COMMIT_OVERRIDE
feat: Add IterableAsyncQueue.
feat: Update minimum Java version to 1.8.
END_COMMIT_OVERRIDE


Note

Medium Risk
Raising shared/common’s Java baseline to 1.8 can break consumers pinned to Java 7; the new queue is well-tested but adds new concurrency code paths.

Overview
Adds com.launchdarkly.sdk.collections.IterableAsyncQueue, a thread-safe unbounded FIFO queue whose take() returns a CompletableFuture that completes immediately when items exist or later when put() supplies one, plus package docs.

Updates lib/shared/common to target Java 8 (1.8) and adds an extensive JUnit test suite covering ordering, null handling, and multi-threaded producer/consumer behavior.

Written by Cursor Bugbot for commit e78dcde. This will update automatically on new commits. Configure here.

@kinyoklion kinyoklion marked this pull request as ready for review January 29, 2026 22:00
@kinyoklion kinyoklion requested a review from a team as a code owner January 29, 2026 22:00
@kinyoklion kinyoklion force-pushed the rlamb/add-iterable-async-queue-common branch from 82a437f to 8c1b4bf Compare January 29, 2026 22:06
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@kinyoklion kinyoklion force-pushed the rlamb/add-iterable-async-queue-common branch from 8c1b4bf to dac4a9b Compare January 29, 2026 22:11
@kinyoklion kinyoklion force-pushed the rlamb/add-iterable-async-queue-common branch from dac4a9b to 65e92d5 Compare January 29, 2026 22:13
@kinyoklion kinyoklion merged commit 1965b25 into main Jan 30, 2026
21 checks passed
@kinyoklion kinyoklion deleted the rlamb/add-iterable-async-queue-common branch January 30, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants