Skip to content

refactor(react-sdk): renamed example server-only react-server-example#1237

Open
joker23 wants to merge 1 commit intomainfrom
skz/rename-react-server-example
Open

refactor(react-sdk): renamed example server-only react-server-example#1237
joker23 wants to merge 1 commit intomainfrom
skz/rename-react-server-example

Conversation

@joker23
Copy link
Copy Markdown
Contributor

@joker23 joker23 commented Apr 1, 2026

This PR address the comment on a previous PR (#1218 (comment))


Note

Low Risk
Low risk: this is a rename/reference update across CI, workspace config, and release-please metadata, with only a minor doc comment change in LDIsomorphicProvider. Main risk is broken paths/job names if any downstream tooling still references the old example name.

Overview
Renames the React SDK Next.js RSC example from server-only to react-server-example, updating the Yarn workspace entry, example package name, and example docs.

Updates CI (react.yml), ESLint ignore patterns, and release-please-config.json to point at the new example path/workspace, and adds a brief LDIsomorphicProvider comment linking to the renamed example.

Reviewed by Cursor Bugbot for commit 7336344. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25661 bytes
Compressed size limit: 29000
Uncompressed size: 126143 bytes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31556 bytes
Compressed size limit: 34000
Uncompressed size: 112044 bytes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179331 bytes
Compressed size limit: 200000
Uncompressed size: 829227 bytes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 37015 bytes
Compressed size limit: 38000
Uncompressed size: 202741 bytes

@joker23
Copy link
Copy Markdown
Contributor Author

joker23 commented Apr 1, 2026

@cursor review

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@joker23 joker23 marked this pull request as ready for review April 1, 2026 20:31
@joker23 joker23 requested a review from a team as a code owner April 1, 2026 20:31
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@joker23 joker23 force-pushed the skz/rename-react-server-example branch from 38d7499 to aa7f052 Compare April 3, 2026 19:29
@@ -1,5 +1,5 @@
{
"name": "@internal/react-sdk-example-server-only",
"name": "@internal/react-sdk-example-react-server",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directory and package name convention mismatch

Low Severity

The directory is named react-server-example but the package name is @internal/react-sdk-example-react-server, dropping the -example suffix. This breaks the convention established by the hello-react example, where the directory name hello-react maps directly to package name @internal/react-sdk-example-hello-react. Following the same pattern, the package name here would be @internal/react-sdk-example-react-server-example, or alternatively the directory could be renamed to react-server to match the current package name.

Fix in Cursor Fix in Web

@joker23 joker23 force-pushed the skz/rename-react-server-example branch from aa7f052 to 6f77905 Compare April 3, 2026 21:45
@joker23 joker23 force-pushed the skz/rename-react-server-example branch from 6f77905 to 7336344 Compare April 3, 2026 23:32
@joker23
Copy link
Copy Markdown
Contributor Author

joker23 commented Apr 3, 2026

@cursor review

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

1 issue from previous review remains unresolved.

Fix All in Cursor

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 7336344. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant