Draft
Conversation
This commit will also: - modify the server-only example to demonstrate how to use the isomorphic provider - modify the bundling so client and server can still bundle correcly with isomorphic components - refactor the client side NOOP client to be able to execute well during SSR
c38c86a to
f1c1dc9
Compare
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
c7df1c3 to
be9d2b4
Compare
be9d2b4 to
58f5bd7
Compare
Contributor
Author
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add a vercel edge example showcasing that our Next.js integration is compatible with the edge sdk (in fact it is almost identical to the nodejs version)
Caveat
I did not implement CI for this just yet. Still pending further discussions to properly set things up.
Note
Low Risk
Low risk: changes are isolated to a new example workspace and docs, with no impact on production SDK code paths. The main risk is optional local/test tooling drift (Next/Playwright config) since it is not wired into CI here.
Overview
Adds a new
packages/sdk/react/examples/vercel-edgeNext.js App Router example that evaluates LaunchDarkly flags at the edge via@launchdarkly/vercel-server-sdk+ Vercel Edge Config, and demonstrates server-to-client bootstrap usingcreateLDServerSession/useLDServerSessionandLDIsomorphicProvider.Updates the React examples index README and the root
package.jsonworkspaces list to include the new example, and includes a minimal Playwright e2e smoke test plus standard Next.js/TS config and styling for the sample app.Written by Cursor Bugbot for commit 58f5bd7. This will update automatically on new commits. Configure here.