feat: distro attributetes in telemetry #453
Merged
abelonogov-ld merged 20 commits intomainfrom Apr 4, 2026
Merged
Conversation
- Adjusted the exclusion rules for OpenTelemetry JARs in LDObservability.Fat.csproj to ensure the main autoconfigure JAR is excluded while re-including the autoconfigure-spi JAR. - Added a note in build.gradle.kts to clarify the filtering of OpenTelemetry JARs for NuGet packaging.
…utes * andrey/simpligy-maui-projects: doesn't account version refactor: update OpenTelemetry JAR handling in project files chore: release main (#450) simplify maui projects to do not have repetitions minus 3 dependency address feedback revert incubator Refactor opentelemetry testing Remove instrumentation manager renaming to ObservabilityService to match Swift # Conflicts: # sdk/@launchdarkly/mobile-dotnet/observability/Directory.Build.props
* main: chore: simplify maui project by removing dependency repetitions (#451) fix: Remove 3 dependencies from MAUI Android (3 aar files) (#449) # Conflicts: # sdk/@launchdarkly/mobile-dotnet/android/native/LDObserve/build.gradle.kts # sdk/@launchdarkly/mobile-dotnet/observability/Directory.Build.props
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...e-dotnet/android/native/LDObserve/src/main/java/com/example/LDObserve/ObservabilityBridge.kt
Show resolved
Hide resolved
Vadman97
approved these changes
Apr 1, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
abelonogov-ld
force-pushed
the
andrey/match-attributes
branch
from
dc9539d to
5f349e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How did you test this change?
Are there any deployment considerations?
Note
Medium Risk
Touches native Android/iOS startup paths and dependency packaging, which could affect observability initialization and emitted telemetry if misconfigured. Changes are localized but cross-platform.
Overview
Propagates an explicit
observabilityVersionfrom the .NET layer into native iOS and Android startup, and uses it to settelemetry.distro.*attributes on the native Observability plugins.Aligns version handling so
serviceVersioncomes from user-providedObservabilityOptions(instead of being overwritten by the package version), updates the iOS binding signature accordingly, and refactors iOS option model classes into a newOptionsBridge.swiftfile.Bumps the .NET package version to
0.6.0, adjusts Android native dependency inclusion to excludeopentelemetry-sdk-extension-autoconfigure-*JARs, and extends the sample app to emit a count metric and log within nested spans.Reviewed by Cursor Bugbot for commit 474b14a. Bugbot is set up for automated code reviews on this repo. Configure here.