feat: [SDK-2121] implement session replay for react native android#456
Open
feat: [SDK-2121] implement session replay for react native android#456
Conversation
launchdarkly-upra
bot
changed the title
| mobileKey = mobileKey, | ||
| options = ObservabilityOptions( | ||
| serviceName = serviceName, | ||
| sessionBackgroundTimeout = 10.minutes, |
Contributor
There was a problem hiding this comment.
It should be internal default.
For next PRs: SessionReplay inherit some settings from ObservabilityOptions:
resourceAttributes
sessionBackgroundTimeout
backendUrl
they should be transfered here
|
|
||
| // The context key is a placeholder — the LDClient is offline and never sends it to | ||
| // LaunchDarkly servers. The React Native LDClient manages the real user context. | ||
| val context = LDContext.builder(ContextKind.DEFAULT, "12345").build() |
Contributor
There was a problem hiding this comment.
Comment is not completelly true
Contributor
There was a problem hiding this comment.
SessionReplay uses data from context to send data to server. Do you have other way of passing context currently implemented.
| // calls lifecycle.addObserver() internally, which requires the main thread. | ||
| // Using timeout=0 so we don't block the UI — onPluginsReady() fires | ||
| // synchronously during LDClient.init() regardless of the flag-fetch timeout. | ||
| Handler(Looper.getMainLooper()).post { |
Contributor
There was a problem hiding this comment.
Not sure why State Machine this logic exists here, I hope it wasn't here.
but if needed it has some race conditions.
- currentState is checked outside lock
- later state is being updated outside lock
- state is being modified without @volatile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a fairly straightforward adaptation of the iOS version of the plugin.
How did you test this change?
There are some unit tests, but the primary test was by creating a react native test app, configuring it with my own LD key, and verifying that Android session replay worked the same as iOS session replay.
Are there any deployment considerations?
No.
Note
Medium Risk
Adds a real Android session replay implementation that initializes an offline
LDClientwith observability/session-replay plugins and new native dependencies; main risk is runtime/initialization and threading behavior on Android plus new SDK version coupling.Overview
Adds Android support for session replay in
@launchdarkly/react-native-ld-session-replay, replacing the previous Android "not supported" stubs.Introduces a native
SessionReplayClientAdapterthat configures an offlineLDClientwithObservability+SessionReplayplugins (main-thread init, simple start/stop state machine), maps JS options intoReplayOptions/PrivacyProfile, and wires these behaviors through the React Native module (configure,startSessionReplay,stopSessionReplay) with basic validation/error handling.Updates Android Gradle config to include LaunchDarkly observability + Android SDK dependencies and JUnit5/MockK test setup, and adds unit tests for option mapping/start preconditions plus JS tests ensuring
configure/startSessionReplayare invoked on plugin registration; also adds a no-opgetHooks()to satisfy theLDPlugininterface.Written by Cursor Bugbot for commit 7ba6e77. This will update automatically on new commits. Configure here.
Related Jira issue: SDK-2121: Implement Session Replay for React Native Android.