fix: Enforce strict validation for message parts and forbid extra fields #1
+233
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a2aproject#609 by ensuring producer task cancellation and immediate queue closure when the consumer fails. Includes regression test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Title
fix: Enforce strict validation for message parts and forbid extra fields
Description
This PR addresses an issue where the SUT failed to correctly reject messages containing unsupported part types (e.g., parts with unknown fields like
typeinstead ofkind).Changes
src/a2a/_base.py: UpdatedA2ABaseModelconfiguration to setextra='forbid'. This ensures that Pydantic raises aValidationErrorif any unknown fields are present in the input, preventing invalid data from being silently ignored or coerced.tck/sut_agent.py: Enhanced theexecutemethod to:RootModelparts to access the actual part instance.TextPart,FilePart,DataPart).Verification
test_unsupported_part_kindina2a-tck.uv run pytest tests/optional/features/test_invalid_business_logic.py -k test_unsupported_part_kind{"type": "unsupported_type"}triggers aValidationError(Extra inputs not permitted) and returns a JSON-RPC-32602error.