Open
Conversation
Collaborator
Author
|
This should not run as root. |
Leopere
approved these changes
Jun 14, 2019
Collaborator
Leopere
left a comment
Leopere
left a comment
There was a problem hiding this comment.
This is a good baseline and will function however I would not consider it stable or up to spec with the other containers. I do not recommend using this in production yet but I'll consider it merge-able for now to help along the process of other things like the K8's stuff in #71
Leopere
requested changes
Jun 14, 2019
Collaborator
Leopere
left a comment
Leopere
left a comment
There was a problem hiding this comment.
This should have it's own README.md to explain the state that this container is in and it's current goals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a spee.ch container.
Spee.ch imports its configuration from its own bundle. This means that we need to have the whole configuration at bundle time. Since we don't have the configuration until runtime, this force us to create the bundle at runtime.
Ideally, the final image would not even have npm in it. Simply copying the node_modules from the
prepstage over to theappstage, and mounting the configuration files should be sufficient. However, this would require a change to how spee.ch imports its configuration.For now, this works with the way spee.ch currently works.