Skip to content

Conversation

@scossu
Copy link
Collaborator

@scossu scossu commented Feb 8, 2026

No description provided.

@scossu
Copy link
Collaborator Author

scossu commented Feb 8, 2026

@tventimi this PR introduces the change to the Chinese table that I mentioned in a separate issue. There is no effect for the user and API client (except for your updates), but the next updates would be made on chinese.yml instead of _chinese_base.yml.

Copy link
Collaborator

@RandyBarry RandyBarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the changes that will correct the conversion of vocalic l and vocalic r in Indic scripts.

Copy link
Collaborator

@RandyBarry RandyBarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I defer to Tom Ventimiglia and Stefano's expertise on what these logical changes accomplish in terms of managing mappings of Chinese characters to Latin strings

Copy link
Collaborator

@RandyBarry RandyBarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is good. There's no need for a Chinese base file since Chinese language option is the only one that references it.

RandyBarry
RandyBarry previously approved these changes Feb 8, 2026
@scossu
Copy link
Collaborator Author

scossu commented Feb 8, 2026

@RandyBarry the automated tests are failing because there is a komy_permyak_cyrillic at https://github.com/lcnetdev/scriptshifter/blob/test/scriptshifter/tables/index.yml#L237 , which refers to cyrillic_generic and I assume that's fine; but there is also a permyak_cyrillic at https://github.com/lcnetdev/scriptshifter/blob/test/scriptshifter/tables/index.yml#L388 that doesn't specify a conf, and so it's looking for permyak_cyrillic.yml that doesn't exist. Shall I remove the second entry?

@RandyBarry
Copy link
Collaborator

My intention for permyak_cyrillic was to have an alias to komi_permyak_cyrillic since some people will look for Permyak under "P" and miss it under Komi. It's conf property would be "komi_permyak_cyrillic.yml". I'd prefer to keep "permyak_cyrillic" in the index.

@scossu
Copy link
Collaborator Author

scossu commented Feb 8, 2026

I see there is a komi-permyak_cyrillic.yml.. So, should komi-permyak_cyrillic also point to that? Currently it points at cyrillic_generic.

@RandyBarry
Copy link
Collaborator

"permyak_cyrillic.yml" is identical to "komi-permyak_cyrillic.yml". Both should be listed in the index. Neither has the "conf:" property since both have two exceptions to "cyrillic_generic.yml".

@scossu scossu dismissed stale reviews from RandyBarry and thisismattmiller via 160f081 February 8, 2026 16:05
Copy link
Collaborator

@RandyBarry RandyBarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep "komi-permyak.yml" since it has exceptions to the "cyrillic_generic.yml". "permyak_cyrillic.yml" is just an alias to "komi-permyak_cyrillic.yml" so it's YML file can be deleted and handled in the index.yml only.

@scossu scossu merged commit e390354 into main Feb 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants