-
Notifications
You must be signed in to change notification settings - Fork 7
Santali, Limbu, Tibetan, Chinese updates #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@tventimi this PR introduces the change to the Chinese table that I mentioned in a separate issue. There is no effect for the user and API client (except for your updates), but the next updates would be made on |
RandyBarry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the changes that will correct the conversion of vocalic l and vocalic r in Indic scripts.
RandyBarry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I defer to Tom Ventimiglia and Stefano's expertise on what these logical changes accomplish in terms of managing mappings of Chinese characters to Latin strings
RandyBarry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is good. There's no need for a Chinese base file since Chinese language option is the only one that references it.
|
@RandyBarry the automated tests are failing because there is a |
|
My intention for permyak_cyrillic was to have an alias to komi_permyak_cyrillic since some people will look for Permyak under "P" and miss it under Komi. It's conf property would be "komi_permyak_cyrillic.yml". I'd prefer to keep "permyak_cyrillic" in the index. |
|
I see there is a |
|
"permyak_cyrillic.yml" is identical to "komi-permyak_cyrillic.yml". Both should be listed in the index. Neither has the "conf:" property since both have two exceptions to "cyrillic_generic.yml". |
160f081
RandyBarry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep "komi-permyak.yml" since it has exceptions to the "cyrillic_generic.yml". "permyak_cyrillic.yml" is just an alias to "komi-permyak_cyrillic.yml" so it's YML file can be deleted and handled in the index.yml only.
No description provided.