Conversation
arthurp
changed the title
arthurp
force-pushed
the
arthurp/update-rustc
branch
from
34fae96 to
059cd3d
Compare
|
@aanyas72 I added you because you might be interested and getting exposed to this kind of logistics is useful because no one teaches this and it is important. |
This ignores all new warnins instead of trying to fix them.
* Remove use of format_args_nl * Remove unsafe that is not needed. * Remove feature flags that are now in stable ...
arthurp
force-pushed
the
arthurp/update-rustc
branch
from
51228ad to
aa9a15d
Compare
| }; | ||
| ($($arg:tt)*) => {{ | ||
| $crate::_print(format_args_nl!($($arg)*)); | ||
| $crate::_print(format_args!($($arg)*), true); |
There was a problem hiding this comment.
Is the comment above about this being copied from rust's stdlib still true?
There was a problem hiding this comment.
I don't know why you can no-longer access format_args_nl, but you can't. However based on rust-lang/rust#111060 (comment), format_args!("{}\n", format_args!($($arg)*)) has no overhead, so I'm using that instead.
| .write() | ||
| .inode_cache | ||
| .extract_if(|_, inode| Arc::strong_count(inode) == 1) | ||
| .extract_if(.., |_, inode| Arc::strong_count(inode) == 1) |
There was a problem hiding this comment.
what does this syntax do?
There was a problem hiding this comment.
.. is the unbounded range, so this call operates over the entire collection. I don't know why extract_if would take a range, while other functions don't. drain also takes one. I'm not sure why.
2 participants
This will provide access to newer features if required and simply avoid falling too far behind.
This disables warnings instead of fixing them when possible to keep the PR simple. However, some things must be updated for one reason or another:
expectattributes for things that we do not want to ignore globally.These changes are unlikely to conflict with outstanding work.
This will be followed by PRs to reenable warnings and fix the code that triggered them. I already have many of the changes, I just realized a separate PR was better.