Skip to content

Return uncached sections in getSections() method #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nightenom wants to merge 1 commit into
base: version/main
Choose a base branch
from
Open

Return uncached sections in getSections() method #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/main/java/com/ldtteam/common/fakelevel/FakeChunk.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,12 @@ public boolean isYSpaceEmpty(int p_62075_, int p_62076_)
public LevelChunkSection[] getSections()
{
// don't cache them
return new LevelChunkSection[0];
final FakeLevelChunkSection[] sections = new FakeLevelChunkSection[fakeLevel.getSectionsCount()];
Copy link
Contributor

@Raycoms Raycoms Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we cache this maybe?

for (int i = 0; i < sections.length; i++)
{
sections[i] = new FakeLevelChunkSection(this, i);
}
return sections;
}

@Override
Expand Down