Feature fit map to layer group#39
Open
Compufreak345 wants to merge 7 commits intoleaflet-extras:masterfrom
Open
Feature fit map to layer group#39Compufreak345 wants to merge 7 commits intoleaflet-extras:masterfrom
Compufreak345 wants to merge 7 commits intoleaflet-extras:masterfrom
Conversation
In my testcase the layer-group is still not displayed on the map, but at least it does not throw errors causing the map to not render anymore...
Added missing semicolon & <content></content> so children can actually be found.
leaflet-layer-group working
This property causes the map containing the Layer-Group to be automatically resized to fit the given container. Using more than one container with this set to true will probably cause random behaviour.
Needed for Firefox & Safari to work with dom-repeat.
Might be better to reregister the mutationObserver at the right point, but until now I did not see any issues.
Patch 1 - fix Safari & firefox issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added property fitMapToBounds to get the map automatically resized to fit the bounds of the LayerGroup where this is set to true (so enables functionality like fitToMarkers, but for only selected items). Random behaviour will occur if this is set on multiple elements, but I think it's quite useful anyways.
Contains the changes from pull-request #38 as well.