Skip to content

chore(deps): bump workbox-precaching from 7.3.0 to 7.4.0 #5614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rtibbles merged 1 commit into from
Apr 16, 2026
+3 −12
Merged

chore(deps): bump workbox-precaching from 7.3.0 to 7.4.0 #5614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
"vuetify": "^1.5.24",
"vuex": "^3.0.1",
"workbox-core": "^7.4.0",
"workbox-precaching": "^7.3.0",
"workbox-precaching": "^7.4.0",
Copy link
Copy Markdown
Contributor

@rtibblesbot rtibblesbot Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: With workbox-precaching now at ^7.4.0, its transitive deps (workbox-routing, workbox-strategies) resolve to 7.4.0 in the lockfile, while the direct specifiers on lines 106-108 are still ^7.3.0. Consider bumping workbox-routing, workbox-strategies, and workbox-window to ^7.4.0 as well for consistency. Not blocking — both versions are compatible and this can be done in a follow-up.

"workbox-routing": "^7.3.0",
Copy link
Copy Markdown
Contributor

@rtibblesbot rtibblesbot Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (re-raised, unaddressed from prior review): workbox-routing, workbox-strategies, and workbox-window are still at ^7.3.0 while workbox-core and workbox-precaching are now at ^7.4.0. The lockfile already resolves all four to 7.4.0 anyway, so aligning the specifiers here is a consistency-only change with no functional impact — happy to drop this if it's intentional.

Copy link
Copy Markdown
Contributor

@rtibblesbot rtibblesbot Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (re-raised, unaddressed from prior reviews): workbox-routing, workbox-strategies, and workbox-window are still at ^7.3.0 while workbox-core and workbox-precaching are now at ^7.4.0. The lockfile already resolves all to 7.4.0, so this is a cosmetic consistency change with no functional impact — happy to drop this if intentional.

"workbox-strategies": "^7.3.0",
"workbox-window": "^7.3.0"
Expand Down
13 changes: 2 additions & 11 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading