Skip to content

Trashmodalunit test#5816

Open
Prashant-thakur77 wants to merge 8 commits intolearningequality:unstablefrom
Prashant-thakur77:trashmodalunit-test
Open

Trashmodalunit test#5816
Prashant-thakur77 wants to merge 8 commits intolearningequality:unstablefrom
Prashant-thakur77:trashmodalunit-test

Conversation

@Prashant-thakur77
Copy link
Copy Markdown
Contributor

@Prashant-thakur77 Prashant-thakur77 commented Apr 7, 2026

Summary

Migrates trashModal.spec.js from @vue/test-utils to @testing-library/vue, as part of the broader effort to make Studio's frontend tests more user-centric and resilient to implementation changes.
Manual verification:

  • Logged in as a@a.com, opened a published channel, removed resources, and verified the trash modal behavior .
  • All the test cases passed.
Screencast.From.2026-04-07.16-36-39.webm

References

Closes #5790
See #5789

Reviewer guidance

1)Only trashModal.spec.js was changed.
2) Reviewer need to check if all the needed testcases are present and testing-library is properly used.

AI usage

I used Claude to help plan and implement the migration.I checked other Testing-library implementations and verified the tests written and updated wherever needed.I followed the guidance given in the issue description and its parent issue description.I again checked if all the test cases are passing properly.

@learning-equality-bot
Copy link
Copy Markdown

👋 Hi @Prashant-thakur77, thanks for contributing!

For the review process to begin, please verify that the following is satisfied:

  • Contribution is aligned with our contributing guidelines

  • Pull request description has correctly filled AI usage section & follows our AI guidance:

    AI guidance

    State explicitly whether you didn't use or used AI & how.

    If you used it, ensure that the PR is aligned with Using AI as well as our DEEP framework. DEEP asks you:

    • Disclose — Be open about when you've used AI for support.
    • Engage critically — Question what is generated. Review code for correctness and unnecessary complexity.
    • Edit — Review and refine AI output. Remove unnecessary code and verify it still works after your edits.
    • Process sharing — Explain how you used the AI so others can learn.

    Examples of good disclosures:

    "I used Claude Code to implement the component, prompting it to follow the pattern in ComponentX. I reviewed the generated code, removed unnecessary error handling, and verified the tests pass."

    "I brainstormed the approach with Gemini, then had it write failing tests for the feature. After reviewing the tests, I used Claude Code to generate the implementation. I refactored the output to reduce verbosity and ran the full test suite."

Also check that issue requirements are satisfied & you ran pre-commit locally.

Pull requests that don't follow the guidelines will be closed.

Reviewer assignment can take up to 2 weeks.

@Prashant-thakur77
Copy link
Copy Markdown
Contributor Author

Hlo @MisRob ,I have resolved the issue,do review when you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert trash modal unit tests to Vue Testing Library

3 participants