Readability improvements to documentation#184
Draft
benagricola wants to merge 1 commit intomasterfrom
Draft
Conversation
Simplifies a number of sentences, cleans up redundant wording, fixes a number of spelling errors and introduces further consistency when mentioning constants such as HIT and MISS. Signed-off-by: Ben Agricola <bagricola@squiz.co.uk>
Member
|
Also see PR #178 - @hamishforbes did we drop luarocks support for some reason? I guess either we need a new rockspec or the docs need to be updated for OPM as per that PR? |
Collaborator
|
🤷♂️We never actually used OPM or rocks for installation internally, it was always deployed straight from git for ... reasons. I think we wanted to move to OPM but the lack of support for external (luarocks) dependencies was a problem? In short, I don't know :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies a number of sentences, cleans up redundant wording, fixes a number of spelling errors and introduces further consistency when mentioning constants such as HIT and MISS.