[P043] [JSON] Add feature to output times in JSON by chromoxdor · Pull Request #5524 · letscontrolit/ESPEasy

chromoxdor · 2026-04-07T22:30:14Z

No description provided.

TD-er · 2026-04-07T22:52:21Z

Apart from my comments, how do you like the new JSON/Webform writer classes? :)

chromoxdor · 2026-04-07T23:24:01Z

Apart from my comments, how do you like the new JSON/Webform writer classes? :)

The fact that I was able to write working code with it in minutes speaks for itself :)

TD-er · 2026-04-07T23:34:25Z

Apart from my comments, how do you like the new JSON/Webform writer classes? :)

The fact that I was able to write working code with it in minutes speaks for itself :)

The nice thing is, the same code can also be used to add stuff to a webpage, just hand over a different writer type.

chromoxdor · 2026-04-08T13:07:03Z

Maybe better to add some PLUGIN_TASK_JSON or something more descriptive :) and let it be handled in the plugin code.

That was not so intuitive for me anymore. 😳
I needed some help to figure out how to make the call.

What do you think about the defines? We have a plugin-specific one (FEATURE_P043_CLK_TIMES_JSON) and one for handling extra JSON in general (FEATURE_ADDITIONAL_JSON_FROM_PLUGIN)

chromoxdor · 2026-04-09T10:18:52Z

Never thought that trying to wrap my head around these definitions is such a challenge for me.
@tonhuisman can you take a look?

In the #ifdef PLUGIN_BUILD_MAX_ESP32 section I added:

     #ifndef FEATURE_P043_CLK_TIMES_JSON && defined(USES_P043)
      #define FEATURE_P043_CLK_TIMES_JSON 1
      #define FEATURE_ADDITIONAL_JSON_FROM_PLUGIN 1
     #endif

and at the very end I added:

#if !defined(USES_P043)
  #define FEATURE_P043_CLK_TIMES_JSON 0
  #ifndef FEATURE_ADDITIONAL_JSON_FROM_PLUGIN
    #define FEATURE_ADDITIONAL_JSON_FROM_PLUGIN 0
  #endif
#elif FEATURE_P043_CLK_TIMES_JSON
  #define FEATURE_ADDITIONAL_JSON_FROM_PLUGIN 1
#endif

tonhuisman · 2026-04-09T10:44:29Z

#if !defined(USES_P043)
  #define FEATURE_P043_CLK_TIMES_JSON 0
  #ifndef FEATURE_ADDITIONAL_JSON_FROM_PLUGIN
    #define FEATURE_ADDITIONAL_JSON_FROM_PLUGIN 0
  #endif
#elif FEATURE_P043_CLK_TIMES_JSON
  #define FEATURE_ADDITIONAL_JSON_FROM_PLUGIN 1
#endif

Well, you're effectively doing the same check twice, that last part I'd simplify to:

#ifndef FEATURE_ADDITIONAL_JSON_FROM_PLUGIN
  #define FEATURE_ADDITIONAL_JSON_FROM_PLUGIN 0
#endif

and also add this similar check:

#ifndef FEATURE_P043_CLK_TIMES_JSON
  #define FEATURE_P043_CLK_TIMES_JSON 0
#endif

Oh, and this won't work:

#ifndef FEATURE_P043_CLK_TIMES_JSON && defined(USES_P043)

Should be like:
#if !defined(FEATURE_P043_CLK_TIMES_JSON) && defined(USES_P043)

TD-er · 2026-04-09T13:02:55Z

yep, shorthand notation like #ifdef or #ifndef cannot be combined with logic operators.

chromoxdor · 2026-04-10T17:22:16Z

Last try. I don't know why this is so hard for me.
Maybe one you can give me the right example if this is still not right.

#ifdef PLUGIN_BUILD_MAX_ESP32 section:

#ifdef USES_P043
      #define FEATURE_P043_CLK_TIMES_JSON 1
#endif

and at the very end:

#ifndef FEATURE_P043_CLK_TIMES_JSON
  #define FEATURE_P043_CLK_TIMES_JSON 0
#endif

#if FEATURE_P043_CLK_TIMES_JSON && !defined(USES_P043)
  #define FEATURE_P043_CLK_TIMES_JSON 0
#endif

#if FEATURE_P043_CLK_TIMES_JSON
  #define FEATURE_ADDITIONAL_JSON_FROM_PLUGIN 1
#endif

#ifndef FEATURE_ADDITIONAL_JSON_FROM_PLUGIN
  #define FEATURE_ADDITIONAL_JSON_FROM_PLUGIN 0
#endif

tonhuisman · 2026-04-10T19:09:56Z

#if FEATURE_P043_CLK_TIMES_JSON && !defined(USES_P043)
  #define FEATURE_P043_CLK_TIMES_JSON 0
#endif

Well, there's 1 small issue here 🤣
As FEATURE_P043_CLK_TIMES_JSON is already defined as value 1, the preprocessor will complain about you setting it to 0 here. It should be #undef'ed first:

#if FEATURE_P043_CLK_TIMES_JSON && !defined(USES_P043)
  #undef FEATURE_P043_CLK_TIMES_JSON
  #define FEATURE_P043_CLK_TIMES_JSON 0
#endif

The rest looks OK.

chromoxdor · 2026-04-10T19:33:12Z

The rest looks OK.

Puhhh… I am relieved.
I made an observation while testing.
When changing longitude and latitude for proper sunrise and sunset times, it seems the recalculation only takes place after a reboot. It probably should happen when hitting save, right?

TD-er · 2026-04-10T20:09:16Z

It is being done when the time is set and on a new date.
But I don't see why we shouldn't recalculate this when saving the settings.

TD-er · 2026-04-13T10:52:26Z

+# if FEATURE_ADDITIONAL_JSON_FROM_PLUGIN
+
+              EventStruct TempEvent(TaskIndex);
+              TempEvent.Par1 = reinterpret_cast<intptr_t>(taskWriter.get());


Please don't do nasty things like this. There is a proper pointer in the EventStruct for this.

KeyValueWriter* kvWriter = nullptr;

TD-er · 2026-04-13T10:53:27Z

+    case PLUGIN_TASK_JSON:
+    {
+      addLog(LOG_LEVEL_INFO, F("P043 JSON CALLED"));
+      auto taskWriter = reinterpret_cast<KeyValueWriter *>(event->Par1);


Ditto, please use the already present KeyValueWriter* kvWriter in the EventStruct

TD-er · 2026-04-13T10:58:38Z

+      auto timesWriter = taskWriter->createChildArray(F("Times"));
+      if (!timesWriter) break;
+
+      LoadTaskSettings(event->TaskIndex);


Not 100% sure this is needed as the Cache also does quite a lot of checking.
This is potentially quite a resource intensive operation and should only be done when absolutely needed.

chromoxdor · 2026-04-14T14:06:37Z

@TD-er : If you soon plan to make a new release and find this PR worth merging could you take over for the necessary changes? I am at the hospital right know waiting for a new life to be born and most definitely will not be available for some time.

TD-er · 2026-04-14T14:32:40Z

@TD-er : If you soon plan to make a new release and find this PR worth merging could you take over for the necessary changes? I am at the hospital right know waiting for a new life to be born and most definitely will not be available for some time.

Sure, will do.
And I totally understand the rollercoaster you will experience right now :)

chromoxdor added 2 commits April 8, 2026 00:29

[P043] [JSON] Add feature to output times in JSON

cd2e4b5

[P043] [JSON] Update JSON.cpp

e5d85ac

TD-er reviewed Apr 7, 2026

View reviewed changes

Comment thread src/src/WebServer/JSON.cpp Outdated

TD-er reviewed Apr 7, 2026

View reviewed changes

Comment thread src/src/WebServer/JSON.cpp Outdated

tonhuisman reviewed Apr 8, 2026

View reviewed changes

Comment thread src/src/CustomBuild/define_plugin_sets.h

[P043] [JSON] Adding suggested changes

f1bb011

tonhuisman reviewed Apr 8, 2026

View reviewed changes

Comment thread src/Custom-sample.h Outdated

tonhuisman reviewed Apr 8, 2026

View reviewed changes

Comment thread src/src/CustomBuild/define_plugin_sets.h Outdated

tonhuisman reviewed Apr 8, 2026

View reviewed changes

Comment thread src/src/CustomBuild/define_plugin_sets.h Outdated

[P043] [JSON] Adding suggested changes 2

e72c8b7

TD-er reviewed Apr 13, 2026

View reviewed changes

Conversation

chromoxdor commented Apr 7, 2026

Uh oh!

Uh oh!

Uh oh!

TD-er commented Apr 7, 2026

Uh oh!

chromoxdor commented Apr 7, 2026

Uh oh!

TD-er commented Apr 7, 2026

Uh oh!

Uh oh!

chromoxdor commented Apr 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chromoxdor commented Apr 9, 2026

Uh oh!

tonhuisman commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TD-er commented Apr 9, 2026

Uh oh!

chromoxdor commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tonhuisman commented Apr 10, 2026

Uh oh!

chromoxdor commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TD-er commented Apr 10, 2026

Uh oh!

TD-er Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

TD-er Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

TD-er Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

chromoxdor commented Apr 14, 2026

Uh oh!

TD-er commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tonhuisman commented Apr 9, 2026 •

edited

Loading

chromoxdor commented Apr 10, 2026 •

edited

Loading

chromoxdor commented Apr 10, 2026 •

edited

Loading