Temporarily disable tests depending on SSH#1124
Closed
europaul wants to merge 3 commits intolf-edge:masterfrom
Closed
Temporarily disable tests depending on SSH#1124europaul wants to merge 3 commits intolf-edge:masterfrom
europaul wants to merge 3 commits intolf-edge:masterfrom
Conversation
SSH to EVE is unreliable, causing both tests to fail consistently. Disable them in the smoke suite until the underlying EVE SSH issue is resolved. See lf-edge#1123 Signed-off-by: Paul Gaiduk <paulg@zededa.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The metadata test's ssh.sh script was given only 5 minutes to connect to the app's SSH, but the port forwarding chain (host → QEMU → EVE portmap → app) can take longer to become operational. All SSH attempts showed "Connection timed out during banner exchange", meaning TCP connected but EVE's portmap to the app wasn't ready yet. Increase the timeout to 20 minutes, matching eclient.txt which uses the same SSH retry pattern with a 20-minute timeout. Signed-off-by: Paul Gaiduk <paulg@zededa.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The check_sign_cert.sh script would break out of the retry loop as soon as it found any JSON cert files, then pick the last one alphabetically. When multiple certs existed (old + new), this could pick the old cert since filenames are hashes with no meaningful order. Restructure the script to compare each extracted cert against the expected cert inside the retry loop, and keep retrying until a match is found or the 2-minute exec timeout is reached. Also redirect stderr from ls to /dev/null to prevent SSH error output from polluting the certfiles list. Signed-off-by: Paul Gaiduk <paulg@zededa.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Is it the SSH connectivity that is flaky or sshd logging something when new client connects? |
Contributor
Author
|
@milan-zededa I think it's the SSH connectivity, but now that |
Contributor
eriknordmark
left a comment
eriknordmark
left a comment
There was a problem hiding this comment.
FWIW the changes to ctrl_cert_change and metadata look fine.
But the ssh root cause is evasive.
Contributor
Author
|
@milan-zededa I blame everything on the runners - I tested on the self-hosted setup https://github.com/europaul/eden/actions/runs/23492857272/job/68365581145?pr=2 - everything works so my plan is to wait until #1125 is merged, rebase and profit |
Contributor
Contributor
Author
|
I'm gonna close this PR in favor of #1123 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since SSH to EVE doesn't work reliably, we're going to disable the flaky tests that rely on it
Also this PR fixes two other flaky tests (see the respective commits for details):