Open
Conversation
EatonCiaran
commented
Jul 21, 2021
EatonCiaran
commented
- Fix inconsistent use of single and double quotes. Now favours double quotes.
- Fix inconsistent space and tab indenting, and remove trailing whitespaces. Now 4 space indent.
- Removed unneeded semicolons on function declarations and for loops
- Fix some typos, clarify some comments/messages, more consistent casing
- Fix invalid HTML (lack of title element) and made it HTML 5.
- Rename license file to standard convention
- Remove custom equalTo function and instead use deepEqual for better error messages when type mismatch.
- Make answer prompts more consistent i.e. some hinted for a string, only 1 really needs that
- Flesh out README
- Other general Prettier changes e.g. typeof not needing brackets; add trailing commas to objects and arrays; spaces before brackets, after commas, and between operators.
* Fix inconsistent use of single and double quotes. Now favours double quotes. * Fix inconsistent space and tab indenting, and remove trailing whitespace. Now 4 space indent. * Removed unneeded semicolons on function declarations and for loops * Fix some typos, clarify some comments/messages, more consistent casing * Fix invalid HTML (lack of title element) and made it HTML 5. * Rename license file to standard convention * Remove custom equalTo function and instead use deepEqual for better error messages when type mismatch. * Make answer prompts more consistent i.e. some hinted for a string, only 1 really needs that * Flesh out README * Other general Prettier changes e.g. typeof not needing brackets; add trailing commas to objects and arrays; spaces before brackets, after commas, and between operators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.