-
Notifications
You must be signed in to change notification settings - Fork 301
Make is_prepared() more fine-grained #3759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
|
Does "do not merge" also mean "do not review"? |
It's already bad enough to need fixing, huh? ;-) Nah, please jump in as you see fit. I've got more I'm wanting to add here, but if there's flaws in the foundation then it's probably better to fix them before I put more layers on top. |
lindsayad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just looking at the header this seems like a great foundation to me
7c8c1d1 to
fc6ee94
Compare
fc6ee94 to
e39fc75
Compare
|
This might actually be in shape to merge soon. My remaining concerns:
|
|
Job Coverage, step Generate coverage on b0367ec wanted to post the following: CoverageInconsistent report tags were found between the head and base reports. Inconsistent tags: This comment will be updated on new commits. |
cc7fd1a to
9e6f0db
Compare
7143591 to
6febe53
Compare
We need things like neighbor pointers, and in general we'd like to assert that we're never assembling or solving on unprepared meshes.
We can rebuild point locators or element caches, but we don't want to use an already-built invalid cache by accident.
If we're skipping partitioning, we shouldn't mark ourselves as partitioned if we're not, and we shouldn't expect that we're marked as partitioned.
|
I'm moving the "incredibly careful assertions" part of this PR to a new branch, https://github.com/roystgnr/libmesh/tree/mesh_preparation_assertions, which I'll put into a new PR for after this one goes in. That (plus the other PRs I've just factored out, plus one more bugfix PR that'll wait on #4394 because it requires a commit there) should get this PR down to just the functionality promised in the title, and should leave it in a ready-to-review state. |
6febe53 to
b0367ec
Compare
I'm still trying to figure out how to make this easy to use, but I'd like to at least test that what I've got so far still passes CI.