Test for out-of-mesh-value on bad MeshFunction variable indices#4391
Merged
roystgnr merged 8 commits intolibMesh:develfrom Feb 11, 2026
Merged
Test for out-of-mesh-value on bad MeshFunction variable indices#4391roystgnr merged 8 commits intolibMesh:develfrom
roystgnr merged 8 commits intolibMesh:develfrom
Conversation
We only set the out_of_mesh_value for the first component of gradients when we're using it to indicate a bad variable number
I'd like to add tests later that actually test the use of a out_of_mesh_value for *out-of-mesh* lookups...
Member
|
Member
Author
|
Of course ChatGPT wouldn't think about compatibility with parallel partitioning; it's more embarrassing that I didn't either. |
jwpeterson
approved these changes
Feb 10, 2026
Member
Author
|
Well, I was hoping I could fix things blind, but no such luck. I'll try to have a proper parallel fix tonight when I can plug in my dying Macbook. |
We should instead change the behavior of these functions in the out-of-mesh case, but that will wait on a later PR.
Member
Author
|
I set auto-merge since this definitely adds some feature coverage, but I definitely need to remember to look at the line coverage changes after CI finishes, to see just how bad the ratio there is... |
Member
Author
|
161 lines of tests for 19 lines of (new) coverage. 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial suggestion ChatGPT gave me here was broken, but I added the (simple) fix, as well as an analogous test for the second derivative API.