Update to upstream LDK after 4263 and 4370 #780
+47
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightningdevkit/rust-lightning#4263 and lightningdevkit/rust-lightning#4370 changed the `lightning` API, which we update to here. We also switch to using a `Cargo.toml` `[patch...]` to avoid having to update the `bitcoin-payment-instructions` dep after each bump.
|
I've assigned @tnull as a reviewer! |
tnull
reviewed
Feb 2, 2026
| [patch.'https://github.com/lightningdevkit/rust-lightning'] | ||
| # Cargo won't let us patch a git dependency with another rev from the same git dependency, so we | ||
| # have to pick another copy of `rust-lightning` and pin the rev. | ||
| lightning = { git = "https://git.bitcoin.ninja/rust-lightning", rev = "0bc5c95484345c6289dffd9a379982a9b66d688f" } |
Collaborator
There was a problem hiding this comment.
I don't see how this is preferable. We'll still need to keep that third repository in-sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lightningdevkit/rust-lightning#4263 and lightningdevkit/rust-lightning#4370 changed the
lightningAPI, which we update to here.We also switch to using a
Cargo.toml[patch...]to avoid having to update thebitcoin-payment-instructionsdep after each bump.