Replace REST and RabbitMQ with gRPC#175
Draft
benthecarman wants to merge 1 commit intolightningdevkit:mainfrom
Draft
Replace REST and RabbitMQ with gRPC#175benthecarman wants to merge 1 commit intolightningdevkit:mainfrom
benthecarman wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @joostjager as a reviewer! |
Consolidate the two separate communication protocols (protobuf over REST via Hyper, and RabbitMQ for events) into a single gRPC interface using tonic. This eliminates the RabbitMQ operational dependency and gives clients strongly-typed generated stubs. Events are now delivered via a server-streaming RPC backed by a tokio broadcast channel. HMAC auth moves to a tonic interceptor using timestamp-only signing since TLS guarantees body integrity. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #168, wanted to quickly see what this would look like
Consolidate the two separate communication protocols (protobuf over REST via Hyper, and RabbitMQ for events) into a single gRPC interface using tonic. This eliminates the RabbitMQ operational dependency and gives clients strongly-typed generated stubs.
Events are now delivered via a server-streaming RPC backed by a tokio broadcast channel. HMAC auth moves to a tonic interceptor using timestamp-only signing since TLS guarantees body integrity.