Skip to content

Conversation

@wvanlint
Copy link
Contributor

This PR adds a method to create a Utxo for a SegWit v1 P2TR output, resolving a TODO in ldk-sample: https://github.com/lightningdevkit/ldk-sample/blob/6c300c7b744eddf8e3c5a3336f7c19110b9dab4e/src/bitcoind_client.rs#L431.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jan 31, 2026

👋 I see @wpaulino was un-assigned.
If you'd like another reviewer assignment, please click here.

@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.99%. Comparing base (44b9529) to head (404ead6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4365   +/-   ##
=======================================
  Coverage   85.98%   85.99%           
=======================================
  Files         156      156           
  Lines      102605   102629   +24     
  Branches   102605   102629   +24     
=======================================
+ Hits        88229    88258   +29     
+ Misses      11867    11864    -3     
+ Partials     2509     2507    -2     
Flag Coverage Δ
tests 85.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ldk-reviews-bot
Copy link

🔔 1st Reminder

Hey @wpaulino! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! one doc nit otherwise LGTM

}
}

/// Returns a `Utxo` with the `satisfaction_weight` estimate for a SegWit v1 P2TR output.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this specify that we mean a keypath spend specifically?

@TheBlueMatt TheBlueMatt removed the request for review from wpaulino February 2, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants