-
Notifications
You must be signed in to change notification settings - Fork 436
Add Utxo::new_v1_p2tr #4365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Utxo::new_v1_p2tr #4365
Conversation
|
👋 I see @wpaulino was un-assigned. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4365 +/- ##
=======================================
Coverage 85.98% 85.99%
=======================================
Files 156 156
Lines 102605 102629 +24
Branches 102605 102629 +24
=======================================
+ Hits 88229 88258 +29
+ Misses 11867 11864 -3
+ Partials 2509 2507 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🔔 1st Reminder Hey @wpaulino! This PR has been waiting for your review. |
TheBlueMatt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! one doc nit otherwise LGTM
| } | ||
| } | ||
|
|
||
| /// Returns a `Utxo` with the `satisfaction_weight` estimate for a SegWit v1 P2TR output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this specify that we mean a keypath spend specifically?
This PR adds a method to create a
Utxofor a SegWit v1 P2TR output, resolving a TODO inldk-sample: https://github.com/lightningdevkit/ldk-sample/blob/6c300c7b744eddf8e3c5a3336f7c19110b9dab4e/src/bitcoind_client.rs#L431.