Lease chain fee estimation calculation includes account version#434
Open
ffranr wants to merge 3 commits intolightninglabs:masterfrom
Open
Lease chain fee estimation calculation includes account version#434ffranr wants to merge 3 commits intolightninglabs:masterfrom
ffranr wants to merge 3 commits intolightninglabs:masterfrom
Conversation
The account versions from the spending accounts snapshot will be used in estimating on-chain fees.
Account version is taken from a snapshot of spending account states. This is because the account might be updated to a new version within the batch.
ffranr
force-pushed
the
issue431_lease_chain_fee_estimation
branch
from
0e7a18b to
1a14e73
Compare
Contributor
Author
|
I think the code should be correct at this point. I need to add an itest to subasta to make sure that account updates are handled correctly. I think that the chain fee estimation code should be refactored out of the |
Collaborator
|
@positiveblue: review reminder |
Collaborator
|
Closing due to inactivity |
8 similar comments
Collaborator
|
Closing due to inactivity |
Collaborator
|
Closing due to inactivity |
Collaborator
|
Closing due to inactivity |
Collaborator
|
Closing due to inactivity |
Collaborator
|
Closing due to inactivity |
Collaborator
|
Closing due to inactivity |
Collaborator
|
Closing due to inactivity |
Collaborator
|
Closing due to inactivity |
Contributor
|
!lightninglabs-deploy mute |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to add a test to cover this aspect:
This PR addresses this issue: #431