Add first version of enhanced mapping metadata#81
Conversation
|
The description field you added to TransformationSpecification is actually already inherited from SpecificationComponent (the parent class), so that addition can be removed. The other new fields (publication_date, license, version, creator_id, author_id, mapping_method) are the actual new additions. I'll fix up the conflicts with main and update the tests so this is ready to go. |
|
@matentzn I fixed the conflicts you were running into and I think this could be ready to merge in. If you're happy with what we have here just click the "Ready for review" button to take this off of draft mode. I'll review it and merge it in. |
|
@amc-corey-cox Thank you for looking into this! I still need to review some of these changes with my collaborators; I will let you know when I am happy with it! PS: I will join you soon in your LinkML-map efforts - my funds where approved (yay) |
4f729ab to
3083582
Compare
|
@amc-corey-cox there is no huge rush here, but I think this is in a good enough stage now to merge. Let me know if you have any feedback! |
|
@matentzn I'm working on this one. I had Claude Code help me review it and came up with a bunch of things, some I don't agree with. I'm working through it and trying to get a reasonable review for you. |
Add metadata fields (publication_date, license, version, creator, author, reviewer, mapping_method, documentation, content_url) and Agent class hierarchy (Person, Organization, Software). Enrich personinfo example with metadata fields and update test assertions. Rescued from PR #81 (matentzn), cleaned of unrelated changes that merged independently via #156 and #158. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1014544 to
097bb8d
Compare
Add metadata fields (publication_date, license, version, creator, author, reviewer, mapping_method, documentation, content_url) and Agent class hierarchy (Person, Organization, Software). Enrich personinfo example with metadata fields and update test assertions. Rescued from PR #81 (matentzn), cleaned of unrelated changes that merged independently via #156 and #158. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
097bb8d to
71609ad
Compare
amc-corey-cox
left a comment
There was a problem hiding this comment.
@matentzn - I just have a couple comments here. I don't think any of this needs to be blocking. I would prefer if we get the tests in before the merge but feel free to merge if you just want to get it in. This was sitting a while and took a fair bit of effort to get ready to merge again so we may just want to merge and avoid that happening again.
Add metadata fields to TransformationSpecification aligned with the FAIR Mappings Schema: publication_date, license, version, creator, author, reviewer, mapping_method, documentation, and content_url. Add Agent class hierarchy (Agent, Person, Organization, Software) for structured contributor modeling with type discrimination. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add example demonstrating transformation of LinkML-Map TransformationSpecification metadata to FAIR Mappings Schema format, with sample data, transform spec, and expected output. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
7189c02 to
1012f42
Compare
amc-corey-cox
left a comment
There was a problem hiding this comment.
Sounds good! I'm going to merge.
LinkML-Map transformation specifications previously had minimal metadata — just
id,title, and schema references. This made it difficult to track provenance, authorship, licensing, and versioning of mapping specifications.The FAIR Mappings Schema defines a minimal metadata standard for mapping specifications. By aligning LinkML-Map's
TransformationSpecificationwith this schema (at least a little closer), we enable:Summary of changes
Schema (
transformer_model.yaml):TransformationSpecification:publication_date,license,version,creator,author,reviewer,mapping_method,documentation,content_urlAgentclass hierarchy (Agent,Person,Organization,Software) aligned with FAIR Mappings Schema, supporting polymorphic contributor modeling viadesignates_typeExamples:
personinfo-to-agentexample with real metadata (ORCIDs, license, publication date)Tests:
What's not included (future work)
Sourceobjects forsource_schema/target_schema(see Convertsource_schemaandtarget_schemaslot values into complex tasks #161)source_schema_version,target_schema_version)