Revert SEVERE_THUNDERSTORM title change - title must match ENVO ontology term#36
Open
Copilot wants to merge 3 commits intoenvironmental-health-edoh-valuesetsfrom
Open
Revert SEVERE_THUNDERSTORM title change - title must match ENVO ontology term#36Copilot wants to merge 3 commits intoenvironmental-health-edoh-valuesetsfrom
Copilot wants to merge 3 commits intoenvironmental-health-edoh-valuesetsfrom
Conversation
3 tasks
Co-authored-by: cmungall <50745+cmungall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on environmental health and oncology value sets
Fix SEVERE_THUNDERSTORM enum title to match key and description
Dec 10, 2025
cmungall
requested changes
Dec 13, 2025
Member
cmungall
left a comment
There was a problem hiding this comment.
This should actually fail in PR
Co-authored-by: cmungall <50745+cmungall@users.noreply.github.com>
Contributor
Author
You're right - I've reverted the change in 20b9fd0. The title "convective storm" must match the ENVO:01001294 ontology term label, not the enum key. My previous change would have caused validation to fail because "Severe thunderstorm" doesn't match the ENVO term. |
Copilot
AI
changed the title
Fix SEVERE_THUNDERSTORM enum title to match key and description
Revert SEVERE_THUNDERSTORM title change - title must match ENVO ontology term
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the previous change that updated the
SEVERE_THUNDERSTORMtitle from "convective storm" to "Severe thunderstorm".Issue
The original change conflicted with the repository's validation requirements. In LinkML schemas, the
titlefield must match the label of the ontology term referenced in themeaning:field.Change
SEVERE_THUNDERSTORMtitle back to "convective storm" to match ENVO:01001294The title must align with the ENVO ontology term label rather than the enum key name. The enum evaluator validates that titles/aliases match the actual ontology labels, and "convective storm" is the correct label for ENVO:01001294.
The enum key can be
SEVERE_THUNDERSTORM(for code clarity) while the title matches the ontology term, allowing validation to pass.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.