TPT-4277 Implement support for Reserved IP for IPv4#919
Open
mgwoj wants to merge 6 commits intolinode:proj/reserved-ipsfrom
Open
TPT-4277 Implement support for Reserved IP for IPv4#919mgwoj wants to merge 6 commits intolinode:proj/reserved-ipsfrom
mgwoj wants to merge 6 commits intolinode:proj/reserved-ipsfrom
Conversation
* build(deps): bump golang.org/x/oauth2 from 0.35.0 to 0.36.0 Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.35.0 to 0.36.0. - [Commits](golang/oauth2@v0.35.0...v0.36.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-version: 0.36.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zhiwei Liang <zliang@akamai.com>
…elease notes workflow (linode#913) * Added PR title checking to lint and clean up release notes * Fixed CoPilot suggestions * Exclude dependabot PRs from PR title validation * Address CoPilot suggestions * Add exemptions for hotfixes and external contributions * Switch to using amannn/action-semantic-pull-request@v6 for title validation * Add exemption for dependencies label and remove dependabot author check
* Redact sensitive data from logging * Address copilot suggestions * TPT-4014 Address comments suggestions
Contributor
There was a problem hiding this comment.
Pull request overview
Implements remaining Go SDK (linodego) support for the Reserved IPv4 feature to better align with the API spec, primarily by expanding reserved IP metadata support and adding unit coverage.
Changes:
- Add
reserved_ipv4_addressessupport to tag creation and decode tagged objects of typereserved_ipv4_address. - Add reserved IP tags support plus new endpoints for updating a reserved IP and listing reserved IP types (pricing).
- Add/extend unit tests and fixtures to validate request bodies and response decoding for reserved IP behavior.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tags.go |
Adds tag create option for reserved IPv4 addresses and decodes tagged reserved IP objects. |
network_reserved_ips.go |
Adds tag support for reserving IPs, plus update + types-list endpoints and related models. |
instance_ips.go |
Extends InstanceIP with tags field to capture reserved IP tags. |
test/unit/tag_test.go |
Adds unit coverage for tag create with reserved IPv4 addresses and tagged-object decoding. |
test/unit/nodebalancer_test.go |
Adds request-body validation test for NodeBalancer create with ipv4. |
test/unit/network_reserved_ips_test.go |
Extends reserved IP tests to cover tags, update, and type listing. |
test/unit/network_ips_test.go |
Adds request-body validation for reserve allocation and combined RDNS+reserved update. |
test/unit/instance_test.go |
Adds request-body validation for instance create with explicit IPv4 list. |
test/unit/instance_ip_test.go |
Adds request-body validation for assigning a reserved IP to an instance. |
test/unit/fixtures/tagged_objects_reserved_ip_list.json |
Adds fixture for tagged reserved IPv4 address objects. |
test/unit/fixtures/network_reserved_ips_list.json |
Updates reserved IP list fixture with reserved and tags. |
test/unit/fixtures/network_reserved_ips_get.json |
Updates reserved IP get fixture with reserved and tags. |
test/unit/fixtures/network_reserved_ips.json |
Updates reserve-IP create fixture with reserved and tags. |
test/unit/fixtures/network_reserved_ip_update.json |
Adds fixture for reserved IP update response. |
test/unit/fixtures/network_reserved_ip_types_list.json |
Adds fixture for reserved IP types (pricing) list response. |
Comments suppressed due to low confidence (1)
test/unit/fixtures/network_reserved_ips_list.json:26
- This list fixture is missing the standard "page" field used by paginated list responses in this repo's fixtures. If this fixture is used with getPaginatedResults, pagination decoding may fail or behave inconsistently; add "page": 1 to match other list fixtures.
],
"pages": 1,
"results": 2
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Complete the Go SDK (linodego) support for the Reserved IP feature. Several foundations are already in place; this story addresses the remaining gaps to bring the SDK fully in line with the API Specification.
✔️ How to Test
As the API is not ready yet, there are only mocked integration tests.