Skip to content

TPT-4277 Implement support for Reserved IP for IPv4#919

Open
mgwoj wants to merge 6 commits intolinode:proj/reserved-ipsfrom
mgwoj:feature/TPT-4277-linodego-implement-support-for-reserved-ip-for-ipv4
Open

TPT-4277 Implement support for Reserved IP for IPv4#919
mgwoj wants to merge 6 commits intolinode:proj/reserved-ipsfrom
mgwoj:feature/TPT-4277-linodego-implement-support-for-reserved-ip-for-ipv4

Conversation

@mgwoj
Copy link
Contributor

@mgwoj mgwoj commented Mar 23, 2026

📝 Description

Complete the Go SDK (linodego) support for the Reserved IP feature. Several foundations are already in place; this story addresses the remaining gaps to bring the SDK fully in line with the API Specification.

✔️ How to Test

make test-unit
make TEST_ARGS="-run TestReservedIPAddress" test-int

As the API is not ready yet, there are only mocked integration tests.

dependabot bot and others added 4 commits March 13, 2026 15:12
* build(deps): bump golang.org/x/oauth2 from 0.35.0 to 0.36.0

Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.35.0 to 0.36.0.
- [Commits](golang/oauth2@v0.35.0...v0.36.0)

---
updated-dependencies:
- dependency-name: golang.org/x/oauth2
  dependency-version: 0.36.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* make tidy

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Zhiwei Liang <zliang@akamai.com>
…elease notes workflow (linode#913)

* Added PR title checking to lint and clean up release notes

* Fixed CoPilot suggestions

* Exclude dependabot PRs from PR title validation

* Address CoPilot suggestions

* Add exemptions for hotfixes and external contributions

* Switch to using amannn/action-semantic-pull-request@v6 for title validation

* Add exemption for dependencies label and remove dependabot author check
* Redact sensitive data from logging

* Address copilot suggestions

* TPT-4014 Address comments suggestions
@mgwoj mgwoj requested a review from a team as a code owner March 23, 2026 12:40
@mgwoj mgwoj requested review from Copilot, vshanthe and yec-akamai and removed request for a team March 23, 2026 12:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements remaining Go SDK (linodego) support for the Reserved IPv4 feature to better align with the API spec, primarily by expanding reserved IP metadata support and adding unit coverage.

Changes:

  • Add reserved_ipv4_addresses support to tag creation and decode tagged objects of type reserved_ipv4_address.
  • Add reserved IP tags support plus new endpoints for updating a reserved IP and listing reserved IP types (pricing).
  • Add/extend unit tests and fixtures to validate request bodies and response decoding for reserved IP behavior.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tags.go Adds tag create option for reserved IPv4 addresses and decodes tagged reserved IP objects.
network_reserved_ips.go Adds tag support for reserving IPs, plus update + types-list endpoints and related models.
instance_ips.go Extends InstanceIP with tags field to capture reserved IP tags.
test/unit/tag_test.go Adds unit coverage for tag create with reserved IPv4 addresses and tagged-object decoding.
test/unit/nodebalancer_test.go Adds request-body validation test for NodeBalancer create with ipv4.
test/unit/network_reserved_ips_test.go Extends reserved IP tests to cover tags, update, and type listing.
test/unit/network_ips_test.go Adds request-body validation for reserve allocation and combined RDNS+reserved update.
test/unit/instance_test.go Adds request-body validation for instance create with explicit IPv4 list.
test/unit/instance_ip_test.go Adds request-body validation for assigning a reserved IP to an instance.
test/unit/fixtures/tagged_objects_reserved_ip_list.json Adds fixture for tagged reserved IPv4 address objects.
test/unit/fixtures/network_reserved_ips_list.json Updates reserved IP list fixture with reserved and tags.
test/unit/fixtures/network_reserved_ips_get.json Updates reserved IP get fixture with reserved and tags.
test/unit/fixtures/network_reserved_ips.json Updates reserve-IP create fixture with reserved and tags.
test/unit/fixtures/network_reserved_ip_update.json Adds fixture for reserved IP update response.
test/unit/fixtures/network_reserved_ip_types_list.json Adds fixture for reserved IP types (pricing) list response.
Comments suppressed due to low confidence (1)

test/unit/fixtures/network_reserved_ips_list.json:26

  • This list fixture is missing the standard "page" field used by paginated list responses in this repo's fixtures. If this fixture is used with getPaginatedResults, pagination decoding may fail or behave inconsistently; add "page": 1 to match other list fixtures.
    ],
    "pages": 1,
    "results": 2
}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mgwoj and others added 2 commits March 23, 2026 14:23
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mgwoj mgwoj changed the title TPT-4277 Implement support for Reserved IP for IPv4 feat: TPT-4277 Implement support for Reserved IP for IPv4 Mar 23, 2026
@mgwoj mgwoj added the new-feature for new features in the changelog. label Mar 24, 2026
@mgwoj mgwoj changed the base branch from main to proj/reserved-ips March 24, 2026 13:45
@mgwoj mgwoj changed the title feat: TPT-4277 Implement support for Reserved IP for IPv4 TPT-4277 Implement support for Reserved IP for IPv4 Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature for new features in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants