test: [UIE-9903] - Add QA tags for Product Referrals category sections#13372
Open
jdamore-linode wants to merge 1 commit intolinode:developfrom
Open
test: [UIE-9903] - Add QA tags for Product Referrals category sections#13372jdamore-linode wants to merge 1 commit intolinode:developfrom
jdamore-linode wants to merge 1 commit intolinode:developfrom
Conversation
Collaborator
Cloud Manager UI test results🎉 866 passing tests on test run #1 ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This is a very tiny PR to add a
data-qa-product-categorytag to the div containing Products for a given category on the new Partner Referrals page. This allows us to more reliably assert that the expected products are shown under the expected category from our tests.I don't think a changeset is necessary for this, but am happy to add one if anybody disagrees.
Changes 🔄
data-qa-product-categoryQA tagScope 🚢
Target release date 🗓️
N/A.
Preview 📷
How to test 🧪
Not strictly necessary, but you can confirm that the change is applied as expected by observing the
data-qa-product-categorytag on the div containing the category heading and product cards.Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅