Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import { Divider, useTheme } from '@mui/material';
import { useTheme } from '@mui/material';
import Box from '@mui/material/Box';
import React from 'react';
import { Controller, useFormContext } from 'react-hook-form';

import { AssignedPermissionsPanel } from 'src/features/IAM/Shared/AssignedPermissionsPanel/AssignedPermissionsPanel';
import { Divider } from 'src/features/IAM/Shared/Divider/Divider';

import type { RoleView } from 'src/features/IAM/Shared/types';
import type { AssignNewRoleFormValues } from 'src/features/IAM/Shared/utilities';
Expand All @@ -28,10 +29,8 @@ export const AssignSingleSelectedRole = ({
<Box display="flex" flexDirection="column" sx={{ flex: '5 1 auto' }}>
{index !== 0 && (
<Divider
sx={{
marginBottom: theme.tokens.spacing.S6,
marginTop: theme.tokens.spacing.S12,
}}
spacingBottom={theme.tokens.spacing.S6}
spacingTop={theme.tokens.spacing.S12}
/>
)}

Expand Down
19 changes: 19 additions & 0 deletions packages/manager/src/features/IAM/Shared/Divider/Divider.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import { screen } from '@testing-library/react';
import React from 'react';

import { renderWithTheme } from 'src/utilities/testHelpers';

import { Divider } from './Divider';

describe('Divider', () => {
it('renders an hr element', () => {
renderWithTheme(<Divider />);
screen.getByRole('separator');
});

it('applies spacingTop and spacingBottom styles', () => {
renderWithTheme(<Divider spacingBottom="16px" spacingTop="8px" />);
const hr = screen.getByRole('separator');
expect(hr).toHaveStyle({ marginTop: '8px', marginBottom: '16px' });
});
});
25 changes: 25 additions & 0 deletions packages/manager/src/features/IAM/Shared/Divider/Divider.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import { omittedProps, styled } from '@linode/ui';
import React from 'react';

export interface DividerProps {
spacingBottom?: number | string;
spacingTop?: number | string;
}

export const Divider = (props: DividerProps) => {
return <StyledDivider {...props} />;
};

export const StyledDivider = styled('hr', {
label: 'StyledDivider',
shouldForwardProp: omittedProps(['spacingTop', 'spacingBottom']),
})<DividerProps>(({ theme, spacingTop, spacingBottom }) => ({
display: 'block',
margin: `${theme.tokens.spacing.S8} 0`,
width: '100%',
borderWidth: '0 0 thin',
borderStyle: 'solid',
borderColor: theme.tokens.component.Divider.Border,
marginBottom: spacingBottom,
marginTop: spacingTop,
}));
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
import { Autocomplete, Button, DeleteIcon } from '@linode/ui';
import { Divider, useTheme } from '@mui/material';
import { useTheme } from '@mui/material';
import Box from '@mui/material/Box';
import React from 'react';
import { Controller, useFormContext } from 'react-hook-form';

import { AssignedPermissionsPanel } from 'src/features/IAM/Shared/AssignedPermissionsPanel/AssignedPermissionsPanel';
import { getRoleByName } from 'src/features/IAM/Shared/utilities';

import { Divider } from '../../Shared/Divider/Divider';

import type { IamAccountRoles } from '@linode/api-v4';
import type {
AssignNewRoleFormValues,
Expand Down Expand Up @@ -40,10 +42,8 @@ export const AssignSingleRole = ({
<Box display="flex" flexDirection="column" sx={{ flex: '5 1 auto' }}>
{index !== 0 && (
<Divider
sx={{
marginBottom: theme.tokens.spacing.S24,
marginTop: theme.tokens.spacing.S20,
}}
spacingBottom={theme.tokens.spacing.S24}
spacingTop={theme.tokens.spacing.S20}
/>
)}

Expand Down
Loading