Conversation
cc75474 to
69c8e18
Compare
69c8e18 to
e8b4699
Compare
kalvdans
left a comment
There was a problem hiding this comment.
Best would be a rust-only library (hidraw-rs comes up from a search) but change looks fine!
|
|
||
| ## Package Requirements | ||
|
|
||
| - libhidapi-dev/hidapi-devel |
There was a problem hiding this comment.
We should add other dependencies here, (libudev, libdbus-1, libsodium), but we can do as a separate PR.
There was a problem hiding this comment.
@copilot can you take a look (also fix the build issue if you can see the error and test).
|
@AlfioEmanueleFresta I've opened a new pull request, #171, to work on those changes. Once the pull request is ready, I'll request review from you. |
Unverified, from #171 |
|
Hmm. We definitely want to support Ubuntu 24.04, and I'm trying to make this at least compile on Ubuntu 22.04. If this is going to cause issues, then I don't think this is worth much more investigation; we've got higher priority things to work on. I'm fine to close this. |
This is up for discussion, but after removing some other dependencies, I noticed that the compilation time of hidapi increased (12.5 out of 56.3 seconds on my machine)
hidraw is ubiquitous on the OSes versions we target, so I don't think there's any harm in linking to the system library. (There is a note in the docs from over 4 years ago that "hidraw might be buggy in older kernel versions", but I don't think that applies today.)