Skip to content

Comments

Add to_json_value to WebAuthnIDLResponse, rename to_jsonto_json_string#169

Merged
AlfioEmanueleFresta merged 3 commits intomasterfrom
copilot/add-to-json-value-method
Feb 20, 2026
Merged

Add to_json_value to WebAuthnIDLResponse, rename to_jsonto_json_string#169
AlfioEmanueleFresta merged 3 commits intomasterfrom
copilot/add-to-json-value-method

Conversation

Copy link
Contributor

Copilot AI commented Feb 18, 2026

Follow-up from PR #155 discussion: expose both serde_json::Value and formatted String outputs from the response trait.

  • Added to_json_value(&self, ctx) -> Result<serde_json::Value, _> to WebAuthnIDLResponse
  • Renamed to_jsonto_json_string, now delegates to to_json_value internally
  • JsonFormat retained on to_json_string for minified/pretty output
// Get a serde_json::Value for programmatic access
let value = assertion.to_json_value(&request)?;

// Get a formatted string (same as before, renamed)
let json = assertion.to_json_string(&request, JsonFormat::Prettified)?;

All call sites in examples and tests updated to to_json_string.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…uthnIDLResponse trait

Co-authored-by: AlfioEmanueleFresta <621062+AlfioEmanueleFresta@users.noreply.github.com>
Copilot AI changed the title [WIP] Add to_json_value method and modify to_json_string Add to_json_value to WebAuthnIDLResponse, rename to_jsonto_json_string Feb 18, 2026
@AlfioEmanueleFresta AlfioEmanueleFresta marked this pull request as ready for review February 18, 2026 21:17
Copy link
Collaborator

@msirringhaus msirringhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@AlfioEmanueleFresta AlfioEmanueleFresta merged commit 7530618 into master Feb 20, 2026
4 checks passed
@AlfioEmanueleFresta AlfioEmanueleFresta deleted the copilot/add-to-json-value-method branch February 20, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants