Add to_json_value to WebAuthnIDLResponse, rename to_json → to_json_string#169
Merged
AlfioEmanueleFresta merged 3 commits intomasterfrom Feb 20, 2026
Merged
Conversation
…uthnIDLResponse trait Co-authored-by: AlfioEmanueleFresta <621062+AlfioEmanueleFresta@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add to_json_value method and modify to_json_string
Add Feb 18, 2026
to_json_value to WebAuthnIDLResponse, rename to_json → to_json_string
AlfioEmanueleFresta
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from PR #155 discussion: expose both
serde_json::Valueand formattedStringoutputs from the response trait.to_json_value(&self, ctx) -> Result<serde_json::Value, _>toWebAuthnIDLResponseto_json→to_json_string, now delegates toto_json_valueinternallyJsonFormatretained onto_json_stringfor minified/pretty outputAll call sites in examples and tests updated to
to_json_string.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.