Open
Conversation
konradybcio
reviewed
Aug 16, 2024
konradybcio
reviewed
Aug 16, 2024
lumag
reviewed
Aug 28, 2024
lumag
requested changes
Aug 28, 2024
Collaborator
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
- Please rework the capture protocol. On receiving the command from kbd client should open the file and send the command to the server. Then on each chunk received from the server it should append it to the file. Receiving empty capture message should specify that the whole file has been sent. The client should forbid sending more 'capture' commands until previous one has completed.
- Please drop extra YUV conversion. If you need additional information regarding YUV formats please ping me.
RayyanAnsari
force-pushed
the
image-capture
branch
from
44b6651 to
c9cf9cb
Compare
RayyanAnsari
force-pushed
the
image-capture
branch
3 times, most recently
from
ed7b689 to
88fa875
Compare
Member
|
a separate "address review comments" commit is unnecessary (unless it's for your own tracking), as github provides a nice |
RayyanAnsari
force-pushed
the
image-capture
branch
2 times, most recently
from
01208e7 to
5242b6a
Compare
lumag
requested changes
Aug 30, 2024
RayyanAnsari
force-pushed
the
image-capture
branch
from
5242b6a to
8273105
Compare
lumag
approved these changes
Aug 30, 2024
Collaborator
|
@RayyanAnsari last item. "The base branch requires all commits to be signed. Learn more about signing commits." |
Add support for capturing an image from the server and saving it on the client with a new command, ^A i. Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>
RayyanAnsari
force-pushed
the
image-capture
branch
from
8273105 to
00b5fc2
Compare
Author
|
The commit should now be signed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for capturing an image from the server and saving it on the client with a new command, ^A i.