mi: make private-mi.h include conditional on MI support#3275
Closed
bgoing-micron-oss wants to merge 1 commit intolinux-nvme:masterfrom
Closed
mi: make private-mi.h include conditional on MI support#3275bgoing-micron-oss wants to merge 1 commit intolinux-nvme:masterfrom
bgoing-micron-oss wants to merge 1 commit intolinux-nvme:masterfrom
Conversation
MI support was made optional, but lib.c still included private-mi.h unconditionally. Made include contitional based on MI support. Signed-off-by: Broc Going <bgoing@micron.com>
Contributor
Author
|
This was an attempt to avoid including poll.h from private-mi.h when building on Windows, but it is failing the minimal build. Additional testing on a Linux build configured with
I'll put together a different PR with those changes for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MI support was made optional, but lib.c still included private-mi.h unconditionally. Made include contitional based on MI support.