ci: use ANSIBLE_INJECT_FACT_VARS=false by default for testing

[richm]

Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example, ansible_distribution is now deprecated in favor of
ansible_facts["distribution"]. This is due to making the default
setting INJECT_FACTS_AS_VARS=false. For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

In order to ensure that commits and PRs conform to this, use
ANSIBLE_INJECT_FACT_VARS=false by default in our CI testing.

Update README-ostree.md if needed.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Configure CI workflows to test with Ansible facts not injected as variables by default.

CI:

• Set ANSIBLE_INJECT_FACT_VARS=false in qemu-kvm integration test workflow.
• Propagate SR_ANSIBLE_INJECT_FACT_VARS=false through the TFT CI workflow environment.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Configures CI and test tooling to run Ansible with ANSIBLE_INJECT_FACT_VARS/SR_ANSIBLE_INJECT_FACT_VARS disabled by default, aligning tests with the Ansible 2.20+ deprecation of fact variables.

Flow diagram for CI job setting SR_ANSIBLE_INJECT_FACT_VARS=false

flowchart TD
  A["CI workflow tft.yml starts"] --> B["Prepare test job command"]
  B --> C["Set SR_ARTIFACTS_DIR"]
  C --> D["Set SR_TEST_LOCAL_CHANGES=false"]
  D --> E["Set SR_LSR_USER"]
  E --> F["Set SR_ANSIBLE_INJECT_FACT_VARS=false"]
  F --> G["Set SR_ARTIFACTS_URL"]
  G --> H["Run test tooling with SR_ANSIBLE_INJECT_FACT_VARS=false in environment"]
  H --> I["Ansible runs with INJECT_FACTS_AS_VARS disabled"]
  I --> J["Tests validate ansible_facts based usage"]

Loading

File-Level Changes

Change	Details	Files
Run qemu-kvm integration tests in CI with ANSIBLE_INJECT_FACT_VARS disabled to surface deprecated fact-variable usage.	Set ANSIBLE_INJECT_FACT_VARS environment variable to "false" at the workflow job level so all steps inherit it during qemu-kvm integration tests	.github/workflows/qemu-kvm-integration-tests.yml
Propagate the disabled fact-variable injection setting into TFT-based system roles tests.	Extend the Terraform/test framework variable export string to include SR_ANSIBLE_INJECT_FACT_VARS=false so downstream test harnesses run with fact vars injection disabled	.github/workflows/tft.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}