Skip to content

fix: prevent password leakage in ModifyPasswd #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ComixHe merged 1 commit into from
Mar 4, 2026
Merged

fix: prevent password leakage in ModifyPasswd #1044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions accounts1/users/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ const (
userCmdDelete = "userdel"
userCmdModify = "usermod"
userCmdGroup = "gpasswd"
pwdCmdModify = "chpasswd"

cmdGroupDel = "groupdel"
cmdChAge = "chage"
Expand Down
14 changes: 13 additions & 1 deletion accounts1/users/prop.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,19 @@ func ModifyPasswd(words, username string) error {
return errInvalidParam
}

return doAction(userCmdModify, []string{"-p", words, username})
cmd := exec.Command(pwdCmdModify, "-e")
input := fmt.Sprintf("%s:%s\n", username, words)
cmd.Stdin = bytes.NewBufferString(input)

var stderr bytes.Buffer
cmd.Stderr = &stderr

err := cmd.Run()
if err != nil {
return fmt.Errorf("failed to modify password: %v, %s", err, stderr.String())
}

return nil
}

func ModifyMaxPasswordAge(username string, nDays int) error {
Expand Down
Loading