You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In some scenarios the conda plugin has to be installed before the linuxdeploy process (not as a linuxdeploy plugin), e.g. when a Python environment is needed to build the application.
In this case, a cleanup must not be performed before the actual linuxdeploy process, but after it. Therefore it must be possible to skip the install part.
I see your point. But I think your approach is wrong here. I'd rather introduce a CONDA_CLEANUP_ONLY, which carries your intention a lot better. I guess the name is inspired by CONDA_SKIP_CLEANUP. However, I don't think this tool has two stages "install" and "cleanup" (I think more fine grainedly), or that it will be like that forever. CONDA_CLEANUP_ONLY is exactly the opposite of CONDA_SKIP_CLEANUP.
Have you seen linuxdeploy/linuxdeploy#68? Would introducing such stages fix the issue for you, or do you really need/want to manually set up a conda dir, then run your own script stuff, and then move on to cleaning up? I think with stages and a custom linuxdeploy plugin, you could likely achieve what you want to, too, but this is just a guess. I'd like to hear more about your use case. Perhaps you can share a script?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some scenarios the conda plugin has to be installed before the linuxdeploy process (not as a linuxdeploy plugin), e.g. when a Python environment is needed to build the application.
In this case, a cleanup must not be performed before the actual linuxdeploy process, but after it. Therefore it must be possible to skip the install part.