Skip to content

fix: display of repositories in search modals (CM-1006) #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joanagmaia merged 3 commits into from
Mar 3, 2026
Merged

fix: display of repositories in search modals (CM-1006) #1718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6a5abe
fix: display of repositories in search modals
joanagmaia Mar 2, 2026
f7a080e
fix: hostname matching
joanagmaia Mar 2, 2026
f6d5581
Merge branch 'main' into fix/repos-urls-filters
emlimlf Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions frontend/app/components/shared/layout/search/search-result.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,17 +67,17 @@ SPDX-License-Identifier: MIT

<!-- Repositories -->
<div
v-if="tab === 'all' && props.repositories.length > 0"
v-if="tab === 'all' && repositories.length > 0"
class="pt-3 px-3 text-xs font-semibold leading-5 text-neutral-400"
>
Repositories
</div>
<section
v-if="tab === 'all' || (tab === 'repositories' && props.repositories.length > 0)"
v-if="tab === 'all' || (tab === 'repositories' && repositories.length > 0)"
class="flex flex-col gap-1"
>
<nuxt-link
v-for="repository of props.repositories"
v-for="repository of repositories"
:key="repository.slug"
:to="{
name: LfxRoutes.REPOSITORY,
Expand All @@ -102,7 +102,7 @@ SPDX-License-Identifier: MIT
</nuxt-link>
</section>
<section
v-if="tab === 'repositories' && props.repositories.length === 0"
v-if="tab === 'repositories' && repositories.length === 0"
class="px-3 py-12 flex flex-col items-center"
>
<lfx-icon
Expand Down Expand Up @@ -180,6 +180,7 @@ import LfxAvatar from '~/components/uikit/avatar/avatar.vue';
import LfxIcon from '~/components/uikit/icon/icon.vue';
import { LfxRoutes } from '~/components/shared/types/routes';
import LfxArchivedTag from '~/components/shared/components/archived-tag.vue';
import { normalizeRepoName } from '~/components/shared/utils/helper';

const props = defineProps<{
projects: SearchProject[];
Expand All @@ -193,6 +194,18 @@ const tab = ref('all');

const noResult = computed(() => !props.projects.length && !props.repositories.length && !props.collections.length);

const repositories = computed(() =>
Comment thread
joanagmaia marked this conversation as resolved.
props.repositories.map((repository) => ({
...repository,
name: normalizeRepoName({
...repository,
url: repository.name,
score: 0,
rank: 0,
Comment thread
joanagmaia marked this conversation as resolved.
}),
})),
);

const tabs = [
{
value: 'all',
Expand Down
16 changes: 10 additions & 6 deletions frontend/app/components/shared/utils/helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,21 @@ export const isElementVisible = (element: HTMLElement) => {
export const normalizeRepoName = (repo: ProjectRepository): string => {
try {
const url = new URL(repo.url);
const { hostname } = url;
const pathParts = url.pathname.split('/').filter(Boolean);

// return last 2 segments (owner/repo)
if (pathParts.length > 2) {
return pathParts.slice(-2).join('/');
if (!pathParts.length) {
return repo.name;
}

// Fallback: return repo name or last path segment
return pathParts[pathParts.length - 1] || repo.name;
// GitHub, GitLab and Git repos: always show owner/repo (last 2 path segments)
if (hostname === 'github.com' || hostname === 'gitlab' || hostname === 'git.') {
return pathParts.length >= 2 ? pathParts.slice(-2).join('/') : pathParts[0] || '';
}

// For all other platforms (Gerrit): show full path after domain
return pathParts.join('/');
} catch {
// If URL parsing fails, return the repo name as fallback
return repo.name;
}
};