[WIP] Add a dialog to unmount devices when using Wayland#3558
Open
bigbruno wants to merge 1 commit intolinuxmint:masterfrom
Open
[WIP] Add a dialog to unmount devices when using Wayland#3558bigbruno wants to merge 1 commit intolinuxmint:masterfrom
bigbruno wants to merge 1 commit intolinuxmint:masterfrom
Conversation
Member
Author
|
With the modification that I implemented, in Wayland a dialog also appears informing what is in use, it is a simpler dialog, it does not detect the program icon, but it is working, while in X11 it continues exactly with the dialog that was already used. The text is in Brazilian Portuguese because it is my native language, it is the text received through GVFS, so it is the same text of the dialog that already existed and will use the system language. |
|
are there any updates on this? |
Member
|
This is being implemented for the Cinnamon session in linuxmint/cinnamon#13145, and will eventually provide this dialog for both x11 and wayland. I'm not sure we'd need this at that point, but I'm leaving it open until that other PR is resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The dialog that confirms the unmount of devices that are in use by some program uses resources that are incompatible with wayland and generates segmentation fault. I added a check so that in case you are using wayland, another dialog that is compatible can be created.
Resolves the problem reported in: linuxmint/wayland#134