Skip to content

libnemo-private: fix use-after-free crash in nemo_file_mark_gone #3724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KonTy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

libnemo-private: fix use-after-free crash in nemo_file_mark_gone #3724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions libnemo-private/nemo-file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7947,11 +7947,18 @@ nemo_file_mark_gone (NemoFile *file)

/* Let the directory know it's gone. */
directory = file->details->directory;
/* Hold a temporary ref so the object stays alive through both
* nemo_directory_remove_file() (which may drop the last directory ref
* and free the object) AND the nemo_file_clear_info() call below.
* Without this, remove_file can free the NemoFile and clear_info then
* dereferences the freed pointer, causing a SIGSEGV (bug #3712). */
nemo_file_ref (file);
if (!nemo_file_is_self_owned (file)) {
nemo_directory_remove_file (directory, file);
}

nemo_file_clear_info (file);
nemo_file_unref (file);

/* FIXME bugzilla.gnome.org 42429:
* Maybe we can get rid of the name too eventually, but
Expand Down
Loading