Conversation
`CtElement` will also need to be replaced at some point
rcosta358
force-pushed
the
new-diagnostics
branch
from
4904ad2 to
dc17425
Compare
CatarinaGamboa
approved these changes
Nov 13, 2025
Collaborator
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
There was a problem hiding this comment.
left some comments but nothing major, feel free to address them or leave them for another time
| @@ -14,51 +16,44 @@ | |||
|
|
|||
| public class CommandLineLauncher { | |||
| public static void main(String[] args) { | |||
Collaborator
There was a problem hiding this comment.
We can add these examples in the javadoc of the method
Collaborator
Author
There was a problem hiding this comment.
Actually I don't think those comments are accurate, the path liquidjava-example/src/main/java/ works fine on VS Code.
|
|
||
| public CustomError(String message) { | ||
| super("Found Error", message, null); | ||
| super("Found Error", message, null, null, null); |
Collaborator
There was a problem hiding this comment.
we should avoid having nulls, but if you think its needed its fine
| } | ||
| } | ||
|
|
||
| private static boolean isCorrect(String path) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #81 and based on #109 (already performed rebase).
ErrorHandlerwas removedErrorEmitterwas replaced byLJDiagnostics, which is now referenced statically to avoid passing it as an argument throughout the codeErrors still need to be refactored for better clarity.