Merged
Conversation
CatarinaGamboa
requested changes
Jul 27, 2025
Collaborator
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
There was a problem hiding this comment.
Give an explanation of why this change is necessary and add an example to the test suite that uses this feature - we want to check if it is working properly moving forward.
After merging #46 rebase so that the files here are only the relevant ones for this PR
| @@ -18,8 +19,8 @@ public static void main(String[] args) { | |||
| // In eclipse only needed this:"../liquidjava-example/src/main/java/" | |||
| // In VSCode needs: | |||
| // "../liquidjava/liquidjava-umbrella/liquidjava-example/src/main/java/liquidjava/test/project"; | |||
Collaborator
There was a problem hiding this comment.
Let's add some indications of how to use the this if no args are provided
if (args.length == 0) {
System.out.println("Usage: java MyProgram <arg1> <arg2> [optional_arg3]");
System.out.println(" arg1: Description of first argument");
System.out.println(" arg2: Description of second argument");
System.out.println(" optional_arg3: Description of optional third argument");
return;
}|
|
||
| public static ErrorEmitter launch(String file) { | ||
| System.out.println("Running LiquidJava on: " + file); | ||
| public static ErrorEmitter launch(String... files) { |
Collaborator
There was a problem hiding this comment.
And lets also add javadoc to this one, explaining what these files are
Collaborator
|
@rodrigomilisse are you still planning on making changes before we merge? |
Collaborator
|
This change gives users more flexibility to verify multiple programs at the same time. |
CatarinaGamboa
approved these changes
Oct 29, 2025
rcosta358
force-pushed
the
multiple_args
branch
from
3f07c62 to
9d3344e
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit includes changes from
readme/fixandghost-booleanbranch because of a rebasing mistake, These changes should be ignored.Issues: #47 #48