Check Method Signatures in External Refinements#76
Merged
rcosta358 merged 7 commits intoliquid-java:mainfrom Nov 5, 2025
Merged
Check Method Signatures in External Refinements#76rcosta358 merged 7 commits intoliquid-java:mainfrom
rcosta358 merged 7 commits intoliquid-java:mainfrom
Conversation
CatarinaGamboa
approved these changes
Nov 5, 2025
Collaborator
CatarinaGamboa
left a comment
There was a problem hiding this comment.
Great! This is very helpful and the error message is awesome 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an improvement to #66. In external refinements, instead of just checking the name and parameter count of methods, we now check their whole signatures, including name, parameter count, parameter types and return type.
When a method cannot be found with the exact signature, a list of methods with the same name is provided in the error message, if available.
Example: