Skip String Literals in OperationsChecker#89
Merged
rcosta358 merged 1 commit intoliquid-java:mainfrom Nov 8, 2025
Merged
Conversation
Collaborator
|
FYI, o SMT tem um suporte limitado para string e concatenação de strings (e tamanho de strings). Tal como 1 é selfified para {x:Int | x == 1}, "ola" devia ser selfified para {x:String | x == "ola"}. Imagino que o Z3 Java tenha um binding correspondente. |
CatarinaGamboa
approved these changes
Nov 8, 2025
Collaborator
CatarinaGamboa
left a comment
There was a problem hiding this comment.
Good catch! What a strange error 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is similar to #63.
There was a problem where this simple program failed parsing:
This was because strings were not being handled in the binary operations, in this case string concatenation.
It was fixed by skipping string literals in the
OperationsChecker.