fix(playground): fix playground issues on safari#1437
Conversation
ffc0826 to
81ddca0
Compare
|
A live preview of this PR will be available at the URL(s) below. https://pr1437-81ddca0---lit-dev-5ftespv5na-uc.a.run.app/ |
|
@e111077 something is wrong with the indentation of the code sample on the home page, even thought I don't think that's using the playground. |
|
oh did i not push that change up? |
|
oh no it's minifying! |
a4e96bf to
036278f
Compare
|
The editing experience is sooo much better! Confirmed it works well in Safari too. Haven't checked Firefox yet. I did notice one new issue with the playground: if you edit a playground, then switch to another sample, you'll get an alert about unsaved changes. Click OK to continue and then switch samples again and you'll get the alert again even though you didn't edit the new sample. Once in you're in this state the alert shows every time you switch a sample. This does not happen on the deployed version. |
|
@justinfagnani This seems to be an upstream issue. It's firing a change event when the document changes. Working on a PR right now |
|
google/playground-elements#433 can't 100% confirm this is the fix because |
Fix the playground issues on safari by upgrading to codemirror 6 which is playground elements ~0.21
036278f to
f7e09a3
Compare
|
Bumped playground elements and I cannot repro. Can you please double check, @justinfagnani? I’m deving on an iPad and safari is a bit odd. |
augustjk
left a comment
There was a problem hiding this comment.
works good from my testing on Safari 26.0.1
|
Same, look good here |
justinfagnani
left a comment
There was a problem hiding this comment.
🎉
Thanks @e111077 !!
Fix the playground issues on safari by upgrading to codemirror 6 which is playground elements ~0.21
Additional fixes to get CI green: