Fix motion todo example by removing mwc components#1450
Fix motion todo example by removing mwc components#1450
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
It just occurred to me the reason why the MWC components weren't working - they probably just need to be updated to use the newer If you'd rather I do that instead of use native elements like I did in this PR, let me know and I can make that change. |
|
Thanks for looking at this @binlabs! I'm not sure why existing packages would break like this, that's unfortunate. I personally would go for fewer dependencies so there's less likely to be a break like this in the future. We can add some minimal styles to make the native controls look nice for the demo (which maybe you did already). @sorvell wdyt? |
6f840bc to
ba328b3
Compare
ba328b3 to
e969c68
Compare
The Motion: Todo List Transitions example has broken for several months now due to 404s that are occurring when pulling in the Material Web components that this example uses.
See #1429
I tried bumping the version of those packages but faced the same error.
In this PR I simply replaced the MWC elements with their native equivalents. I tried to make the minimum possible change to get this example working again.
Tested and working on Mac in recent versions of Firefox, Safari, Edge and Chrome.
I did have two questions: