Skip to content

[codex] Fix Rollup docs import examples#1464

Open
Formatted wants to merge 1 commit intolit:mainfrom
Formatted:codex/fix-rollup-doc-imports
Open

[codex] Fix Rollup docs import examples#1464
Formatted wants to merge 1 commit intolit:mainfrom
Formatted:codex/fix-rollup-doc-imports

Conversation

@Formatted
Copy link
Copy Markdown

What changed

This updates the Rollup production docs so the example imports match the current package export shapes.

Why

The current snippets fail in a modern ESM setup:

  • @web/rollup-plugin-html no longer provides a default export in the form used by the docs.
  • @rollup/plugin-terser should be imported as a default export.
  • rollup-plugin-minify-html-literals needs CommonJS interop in these examples.

Scope

  • Fix the modern-only Rollup example in v2 and v3 docs.
  • Fix the v2 modern+legacy Rollup example for the same import issues.
  • Leave rollup-plugin-summary unchanged because its documented import already works.

Validation

  • Reproduced the current import failures in a clean temp project with current package versions.
  • Verified the replacement imports load under Node 22 ESM.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Apr 13, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Formatted Formatted marked this pull request as ready for review April 14, 2026 02:57
@Formatted Formatted force-pushed the codex/fix-rollup-doc-imports branch from 34f4d22 to 2469ad3 Compare April 14, 2026 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant